Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues here:
1. yarn2nix bug
The bug is defined in this issue: nix-community/yarn2nix#53
Due to a new linting dependency, we ended up with this in our yarn.lock:
The existing release of yarn2nix fails to differentiate between @types and regular dependencies if their version is exactly the same.
To resolve this, I just rolled the lint dependency back a major version. It still worked and resolved this issue. I ran
yarn run lint
andyarn run lint:fix
to verify the package still works.We can upgrade to the newer version of yarn2nix to prevent this in the future (although its an unlikely outcome). When we tried the newer version of yarn2nix, unexpectedly some packages had to be changed in the package.json (for no apparent reason), and I had to update the bable config handling to get flow passing, and I'd prefer avoid that.
2. yarn.lock version changes
By deleting and recreating the yarn.lock, we lose its value. In this instance, a dependency of a dependency had gone up a minor version, and this caused the break as it had been loosely specified by that parent dependency. I've now specified this resolutely in the package.json, but not deleting and re-creating the yarn.lock will protect us from this.