New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-405] Wait Daedalus to quit before launching app update #2195
[DDW-405] Wait Daedalus to quit before launching app update #2195
Conversation
Hi @daniloprates. The functionality worked perfectly on Mainnet. Is that sufficient for testing purposes ? On Flight it gets stuck on "Trying to fetch the newsfeed " Win and Mac on builds 14590 and 14591 with these messages in the console see screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected. Tested on build 14590 for both Windows and Mac. Great job @daniloprates 👍
@ManusMcCole yes, it's due to the dummy data I've included, which is targeted to mainnet only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This PR changes the way the update installer is launched, waiting first for the app to quit.
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board