[DDW-414] Bump electron and related packages

[topseniors]

This PR updated electron and related packages.
Jira Ticket

Latest test document
Regression Spreadsheet

Previous test documents
Regression Spreadsheet 2
Regression Spreadsheet 1
HW Regression Spreadsheet
OLD test document see here

Todos

• Update electron and related packages
• Update nix shell scripts
• Revert this commit before merging e49537b -> completed in cc71e34

Testing Checklist

• Slack QA thread

App

• Make sure app is working properly

Storybook

• Make sure all the stories are working properly

Testing Summary

QA Summary for build 18923:

QA Summary for build 18923:

New

• [macOS] The error "transaction confirmation failed" is displayed if you create a transaction for Ledger S and connect the device after. Check this screenshot.

• [Windows] Pair a Ledger S device, wait for it to sync and unlock it. Create a transaction without connecting the device, you'll see that Daedalus asks to "Run cardano app" instead of "Connect the Ledger S". A lot of errors are visible in the console. Check this screenshot.
  Note: If you connect the device at this stage, you still can confirm the transaction.

• [Intermittent - Windows] When trying to delete a Ledger S wallet, an error on the console is displayed. The process of deletion can take a while and if you restart Daedalus, the wallet is still there. Check this screenshot to see the error.

Pending

• I attempted to send ADA with balance enough to cover transaction fee. But at the last stage, after clicking "Send" button, the error displayed was "Not enough ada for fees...". Please see fee1, fee2, fee3

Fixed

• I was able to pair Nano S with Mac Catalina, but wasn't able to execute any transaction. On Daedalus Transaction screen displayed "Export the public key on your device" but Nano S device displayed "Waiting for commands"

• Daedalus crashed when I attempted to send ADA but the balance wasn't enough to cover transaction fee. I managed to duplicate the issue with other wallets too (both Byron and Shelley). Please see video

• The "Blank screen fix" issue is ok now, but the state is not persisted after closing Daedalus. To clarify: In this build If you choose "Blank screen fix", when you close and reopen Daedalus, it is off again. In the version from production, it's a state that doesn't change until you deactivate it.

• After "Blank screen fix" is active, it can't be deactivated. Check this video. Happens on all platforms. Reported here

• Error on BigSur when closing Daedalus. Check screenshot. (Reported via Slack)

• Each time I close Daedalus it reopens by itself. Happens on all platforms. Check this video. Reported here.

• Daedalus restarts after choosing "Blank screen fix", but the fix is disabled (it should look like this). Check this video. Reported here.

• Can't pair Ledger devices on macOS and Windows. Reported here, here, here and here.

• Daedalus doesn't restart after selecting "Blank screen fix". Reported here.

• When you select "Blank screen fix", the Cardano node stops, but Daedalus doesn't restart. If you close it manually after this, it would restart, but the "Blank screen fix" won't be enabled. Check this video. Reported here.

Review Checklist

Basics

• PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
• PR is updated to the most recent version of the target branch (and there are no conflicts)
• PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
• CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
• Automated tests: All acceptance and unit tests are passing (yarn test)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
• There are no flow errors or warnings (yarn flow:test)
• There are no lint errors or warnings (yarn lint)
• There are no prettier errors or warnings (yarn prettier:check)
• There are no missing translations (running yarn manage:translations produces no changes)
• Text changes are proofread and approved (Jane Wild / Amy Reeve)
• Japanese text changes are proofread and approved (Junko Oda)
• UI changes look good in all themes (Alexander Rukin)
• Storybook works and no stories are broken (yarn storybook)
• In case of dependency changes yarn.lock file is updated

Code Quality

• Important parts of the code are properly commented and documented
• Code is properly typed with flow
• React components are split-up enough to avoid unnecessary re-renderings
• Any code that only works in main process is neatly separated from components

Testing

• New feature/change is covered by acceptance tests
• New feature/change is manually tested and approved by QA team
• All existing acceptance tests are still up-to-date
• New feature/change is covered by Daedalus Testing scenario
• All existing Daedalus Testing scenarios are still up-to-date

After Review

• Merge the PR
• Delete the source branch
• Move the ticket to done column on the YouTrack board
• Update Slack QA thread by marking it with a green checkmark

[ManusMcCole]

Hi @yakovkaravelov. Here is the summary for build 14720.

New issues
1 - When attempting to open the state directory path on Windows in Daedalus Diagnostics Screen the Open button would not work and I got this electron error in the console. See here
Same issue on Mac

2 - When attempting to send a transaction that is not possible because I do not have enough funds an incorrect error message "Cannot calculate fees while there are pending transactions" is displayed. There are no pending transactions in the wallet. See here

3 - There is an also an error in the console "State snapshot log file creation failed". This is caused by downloading logs. The logs downloaded succesfully success message is still shown. See here

4 - Not able to run Daedalus on Linux. Attempted with both MainNet and TestNet. The only log available is this see log

Test Document
For test document see here

[ManusMcCole]

Hi @yakovkaravelov. I added two more items to my comment above and I updated the test summary in the PR Description

[ManusMcCole]

Hi @yakovkaravelov . Here is the QA Summary for build 14590.

Still Pending Issues. I was able to reproduce the 2 issues below on the new build

1 - On Mac and Windows on All Networks. There is an error in the console "State snapshot log file creation failed". This is caused by downloading logs. The logs downloaded succesfully success message is still shown. See here.I cannot test Linux as it will

2 - Not able to run Daedalus on Linux. Attempted with both MainNet and TestNet. The only log available is this see log

*Fixed *
1 - When attempting to open the state directory path on Windows in Daedalus Diagnostics Screen the Open button would not work and I got this electron error in the console. See here
Same issue on Mac

Not an Isssue for this PR
3 - On Windows when attempting to send a transaction that is not possible because I do not have enough funds an incorrect error message "Cannot calculate fees while there are pending transactions" is displayed. There are no pending transactions in the wallet. See here" it was marked as fixed but today now I notice sometimes there is a delay where Daedalus takes a good few seconds to realise the user does not have enough UTXO for the transaction. The message calculating fees seems to have higher precedence over the "not enough ada. Try sending a smaller amount". See video from newest build.

Test Document
For test document see here

[nikolaglumac]

1 - On Mac and Windows.There is an error in the console "State snapshot log file creation failed". This is caused by downloading logs. The logs downloaded succesfully success message is still shown. See here

@ManusMcCole does this happen on all networks (Mainnet, Testnet, Shelley QA, Flight...)?

cc @yakovkaravelov

[ManusMcCole]

Hi @yakovkaravelov and @nikolaglumac. Build 14950.For "1 - On Mac and Windows.There is an error in the console "State snapshot log file creation failed". This is caused by downloading logs. The logs downloaded succesfully success message is still shown. See here" this issue happens on all Networks on Windows and Mac. I cannot test Linux as it will not launch

Also for "2 - When attempting to send a transaction that is not possible because I do not have enough funds an incorrect error message "Cannot calculate fees while there are pending transactions" is displayed. There are no pending transactions in the wallet. See here" it was marked as fixed but today now I notice sometimes there is a delay where Daedalus takes a good few seconds to realise the user does not have enough UTXO for the transaction. The message calculating fees seems to have higher precedence over the "not enough ada.Try sending a smaller amount". See video from newest build. Im adding this to the report now

[nikolaglumac]

Also for "2 - When attempting to send a transaction that is not possible because I do not have enough funds an incorrect error message "Cannot calculate fees while there are pending transactions" is displayed. There are no pending transactions in the wallet. See here" it was marked as fixed but today now I notice sometimes there is a delay where Daedalus takes a good few seconds to realise the user does not have enough UTXO for the transaction. The message calculating fees seems to have higher precedence over the "not enough ada.Try sending a smaller amount". See video from newest build. Im adding this to the report now

@ManusMcCole I seriously doubt this is specific to this PR. Please test on other builds (2.4.0 release or develop builds) before adding this to the list of issues of this PR.

[miorsufianiohk]

Hi @yakovkaravelov . I have retested on build 15000 on all 3 platforms. Could replicate all the pending issues as listed in "Testing Summary" please see here

[nikolaglumac]

@miorsufianiohk @gabriela-ponce @ManusMcCole @danielmain when can we expect this one to be approved?

[gabriela-ponce]

@nikolaglumac So far the regression is ok. I found a couple of issues that still reproduce from previous builds on macOS:

• If you connect the device after opening the confirmation dialog, you get the message "An error occurred". Check screenshot.

• Can't confirm 2 transactions in a row without disconnecting the device. On the second transaction, the device won't be detected. Check screenshot.

@miorsufianiohk can you please confirm if you reproduce this in Ledger Nano X?

[nikolaglumac]

@gabriela-ponce @miorsufianiohk @ManusMcCole @dmitrii-gaico please re-test all HW scenarios on all platforms and lets get some numbers 🙏

[miorsufianiohk]

@miorsufianiohk can you please confirm if you reproduce this in Ledger Nano X?
@gabriela-ponce , I could confirm that for Nano X on MacOS this happened -> If you connect the device after opening the confirmation dialog, you get the message "An error occurred". See screenshot.

[gabriela-ponce]

@nikolaglumac @danielmain Just finished checking the Ledger S cases on build 19005 for all platforms, and these are the findings:

• Windows and Linux are ok.
• These issues still reproduce in macOS (BigSur). The second issue doesn't happen all the time.

[nikolaglumac]

@nikolaglumac @danielmain Just finished checking the Ledger S cases on build 19005 for all platforms, and these are the findings:

• Windows and Linux are ok.
• These issues still reproduce in macOS (BigSur). The second issue doesn't happen all the time.

@gabriela-ponce is the same issue reproducible on develop or latest release (4.3.1)?

[miorsufianiohk]

@gabriela-ponce is the same issue reproducible on develop or latest release (4.3.1)?
I am unable to reproduce Gabriela's findings for Nano S on both latest release 4.3.1 and latest develop 19015. Currently testing latest build for this PR. Will report later 👍

[dmitrii-gaico]

@nikolaglumac @danielmain Just finished checking the Ledger S cases on build 19005 for all platforms, and these are the findings:

• Windows and Linux are ok.
• These issues still reproduce in macOS (BigSur). The second issue doesn't happen all the time.

@gabriela-ponce is the same issue reproducible on develop or latest release (4.3.1)?

We have validated both scenarios at MacOS Catalina/BigSur | 4.3.1 current release and latest develop. In all cases issues are NOT reproducible.

[nikolaglumac]

Perfect 👌
Please approve the PR once ready and I will merge it 🚀

[nikolaglumac]

A true masterpiece 💯
Amazing work @danielmain 🎉

[miorsufianiohk]

LGTM. Tested on 19020 Testnet with Nano S on Win, BigSur, Catalina and Linux 👍