Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-291] Fix PopOver Themes #2223

Merged
merged 5 commits into from Oct 29, 2020
Merged

Conversation

DominikGuzei
Copy link
Member

This PR fixes the pop over themes after a detailed double-check from @a-rukin:

  • Update to react-polymorph@0.9.6-rc3 (which sets the default pop over font to regular)
  • Fix wrong background colors for some themes
  • Handle the potentially (atm only in cardano theme) different bg color for the status icon tooltip

Screenshots

Cardano Theme:

The cardano theme is "special" because it requires a different tooltip bg color for the status icons:

CleanShot 2020-10-29 at 13 12 56

But the default tooltips should all look like this:

CleanShot 2020-10-29 at 13 13 11


Testing Checklist

This PR is really mostly fixing tooltips styles for the work done in [DDW-291] Smart Tooltip MVP integration, so i don't think a whole QA session is needed here but @a-rukin should take a final look and give approval (because the other PR was merged before he could do that) .…

  • Double-check that all the new tooltips (syncing/connecting, paper wallet info, staking slider) are good 🙏

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

RC3 sets the default font family to regular for all PopOvers
This change also re-introduced the usage of the dedicated theming variable for the status icons bg colors (because in some themes this needs to be different from the default pop over bg color)
@DominikGuzei DominikGuzei requested review from alexander-rukin and a team October 29, 2020 12:21
@DominikGuzei DominikGuzei self-assigned this Oct 29, 2020
@DominikGuzei DominikGuzei changed the title Fix/ddw 291 pop over themes [DDW-291] Fix PopOver theme variables Oct 29, 2020
@DominikGuzei DominikGuzei changed the title [DDW-291] Fix PopOver theme variables [DDW-291] Fix PopOver Themes Oct 29, 2020
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DominikGuzei 💯

@nikolaglumac
Copy link
Contributor

@gnpf @mioriohk can you please re-check status-icon tooltips? As well as the ones for the paper wallets on the wallet settings page (you need to restore Byron wallet for that one to appear)?

Thanks!

Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested on build 14988. Great work @DominikGuzei 👍

@nikolaglumac nikolaglumac merged commit cb00f84 into develop Oct 29, 2020
@iohk-bors iohk-bors bot deleted the fix/ddw-291-pop-over-themes branch October 29, 2020 16:58
@nikolaglumac nikolaglumac added release-2.4.1-FC1 Daedalus Flight and removed ⏳release-vNext labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants