New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-291] Fix PopOver Themes #2223
Conversation
RC3 sets the default font family to regular for all PopOvers
This change also re-introduced the usage of the dedicated theming variable for the status icons bg colors (because in some themes this needs to be different from the default pop over bg color)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @DominikGuzei 💯
@gnpf @mioriohk can you please re-check status-icon tooltips? As well as the ones for the paper wallets on the wallet settings page (you need to restore Byron wallet for that one to appear)? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested on build 14988. Great work @DominikGuzei 👍
This PR fixes the pop over themes after a detailed double-check from @a-rukin:
regular
)Screenshots
Cardano Theme:
The cardano theme is "special" because it requires a different tooltip bg color for the status icons:
But the default tooltips should all look like this:
Testing Checklist
This PR is really mostly fixing tooltips styles for the work done in [DDW-291] Smart Tooltip MVP integration, so i don't think a whole QA session is needed here but @a-rukin should take a final look and give approval (because the other PR was merged before he could do that) .…
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board