[DDW-486] Close Newsfeed on Blur

[DominikGuzei]

This PR implements the small UX feature of closing the Newsfeed when clicking anywhere else in the UI:

Screenshots

---

Testing Checklist

• Slack QA thread
• Please test anything related to the Newsfeed (opening, closing, interacting with news items, etc.)

Testing Summary

For build 15390

Fixed
1 - When the user clicks on Language, Number Format, Date Format or time format the Newsfeed does not automatically close. See video
2 - When I clicked on the grey out area of "Join" and "Import", the Newsfeed didn't close. Please see recording here. Addition: I have taken a screenshot and highlighted the problematic areas in red rectangles See here

---

Review Checklist

Basics

• PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
• PR is updated to the most recent version of the target branch (and there are no conflicts)
• PR has a good description that summarizes all changes
• PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
  • In English
  • In Japanese
• CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
• Automated tests: All acceptance and unit tests are passing (yarn test)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
• There are no flow errors or warnings (yarn flow:test)
• There are no lint errors or warnings (yarn lint)
• There are no prettier errors or warnings (yarn prettier:check)
• There are no missing translations (running yarn manage:translations produces no changes)
• Text changes are proofread and approved (Jane Wild / Amy Reeve)
• Japanese text changes are proofread and approved (Junko Oda)
• UI changes look good in all themes (Alexander Rukin)
• Storybook works and no stories are broken (yarn storybook)
• In case of dependency changes yarn.lock file is updated

Code Quality

• Important parts of the code are properly commented and documented
• Code is properly typed with flow
• React components are split-up enough to avoid unnecessary re-renderings
• Any code that only works in main process is neatly separated from components

Testing

• New feature/change is covered by acceptance tests
• New feature/change is manually tested and approved by QA team
• All existing acceptance tests are still up-to-date
• New feature/change is covered by Daedalus Testing scenario
• All existing Daedalus Testing scenarios are still up-to-date

After Review

• Merge the PR
• Delete the source branch
• Move the ticket to done column on the YouTrack board
• Update Slack QA thread by marking it with a green checkmark

[miorsufianiohk]

Hi @DominikGuzei . For build 15340:

All looks good to me except when I clicked on the grey out area of "Join" and "Import", the Newsfeed didn't close. Please see recording here

[ManusMcCole]

Hi @DominikGuzei. Very minor or perhaps not an issue at all. Similar to Miors findings when the user clicks on Language, Number Format, Date Format or time format the Newsfeed does not automatically close. See video

[DominikGuzei]

Thanks, @mioriohk, and @ManusMcCole - I will look into these issues 👍

[DominikGuzei]

@mioriohk @ManusMcCole please re-check, I generalized the logic so it should work in any scenario now!

[miorsufianiohk]

@DominikGuzei , this is the current findings for build 15388. Only pending issue listed. I have moved fixed issue into testing summary above.

Pending
1 - When I clicked on the grey out area of "Join" and "Import", the Newsfeed didn't close. Please see recording here. Addition: I have taken a screenshot and highlighted the problematic areas in red rectangles See here

[DominikGuzei]

@mioriohk I also tested this and it worked for me 🤔

[DominikGuzei]

@mioriohk oh I just double-checked and indeed it doesn't work 👍 will debug

[nikolaglumac]

@DominikGuzei is this ready for testing again?

[DominikGuzei]

@nikolaglumac @mioriohk yes, ready for final testing 👍

[miorsufianiohk]

Hi @DominikGuzei . Looks good to me on build 15390

Fixed
1 - When I clicked on the grey out area of "Join" and "Import", the Newsfeed didn't close. Please see recording here. Addition: I have taken a screenshot and highlighted the problematic areas in red rectangles See here

[miorsufianiohk]

Great job @DominikGuzei . Approved. 👍

[ManusMcCole]

Looks good 👍

[nikolaglumac]

Great work @DominikGuzei 💯