[DDW-492] Add initial loading state to UTXO screen #2265

DominikGuzei · 2020-12-04T18:49:42Z

This PR adds an initial loading state for the UTXO page:

Screenshots

Testing Checklist

Slack QA thread
The UTXO page should show a loading spinner and not an "empty wallet" message for wallets that have UTXO but are still loading.

Test cases

Scenario 1: Wallet with UTXO, select first time
Given I am on Daedalus
And Daedalus is fully synced
And I have a fully synced wallet with UTXO
When I select the wallet for the first time
And navigate to ‘Wallet UTXO distribution’
Then I will briefly see the text ‘Wallet UTXO distribution’
And I will briefly see the spinner
And the spinner disappears
And I see the text “The wallet contains xxx ADA on x UTXOs ….”
And I see the UTXO graph distribution

Scenario 2: Wallet with no UTXO
Given I am on Daedalus
And Daedalus is fully synced
And I have a fully synced wallet with 0 ADA
When I select the wallet
And navigate to ‘Wallet UTXO distribution’
Then I will see the text ‘Wallet UTXO distribution’
And I will briefly see the spinner
And the spinner disappears
And underneath I will see the text “This wallet is empty….”

Scenario 3: Wallet with UTXO, select the second time
Given I am on Daedalus
And Daedalus is fully synced
And I have a fully synced wallet with UTXO
And I have already checked this wallet for UTXO distribution
When I select the wallet for the second time
And navigate to ‘Wallet UTXO distribution’
Then I will see the text ‘Wallet UTXO distribution’
And I will briefly see the spinner
And the spinner disappears
And I see the text “The wallet contains xxx ADA on x UTXOs ….”
And I see the UTXO graph distribution

Scenario 4: Select another wallet with UTXO, after checking UTXO of the first wallet
Given I am on Daedalus
And Daedalus is fully synced
And I have 2 fully synced wallets with UTXO
And both wallets have never been selected to check UTXO distribution
And I have checked the UTXO distribution of the first wallet
When I select the second wallet
And navigate to ‘Wallet UTXO distribution’
Then I will briefly see the text ‘Wallet UTXO distribution’
And I will briefly see the spinner
And the spinner disappears
And I see the text “The wallet contains xxx ADA on x UTXOs ….”
And I see the UTXO graph distribution

Testing Summary

For build 15559

Test cases	Results	Note
Scenario 1	Pass	Recording for Scenario 1
Scenario 2	Pass	Recording for Scenario 2
Scenario 3	Pass	Recording for Scenario 3
Scenario 4	Pass	Recording for Scenario 4

Review Checklist

Basics

Code Quality

Important parts of the code are properly commented and documented
Code is properly typed with flow
React components are split-up enough to avoid unnecessary re-renderings
Any code that only works in main process is neatly separated from components

Testing

New feature/change is covered by acceptance tests
New feature/change is manually tested and approved by QA team
All existing acceptance tests are still up-to-date
New feature/change is covered by Daedalus Testing scenario
All existing Daedalus Testing scenarios are still up-to-date

After Review

Merge the PR
Delete the source branch
Move the ticket to done column on the YouTrack board
Update Slack QA thread by marking it with a green checkmark

miorsufianiohk · 2020-12-07T12:03:07Z

Hi @DominikGuzei Here is the finding for build 15520.

New issue
1 - I have taken a video of a fully synced wallet and checking the UTXO distribution for the first time. I could still see "The wallet is empty.." message and no spinner. Please refer to video at 00:06 second. Is this expected? I am under the impression that when the wallet has UTXO, the message "The wallet is empty..." will not be displayed at all. Appreciate your confirmation please @DominikGuzei See video

Non issue on this PR
1 - No spinner was observed during loading stage on UTXO page. See video (Dominik to create a new card to fix this)

DominikGuzei · 2020-12-07T15:21:45Z

@mioriohk thanks for the video - you were right, the logic was missing one check 👏
I pushed the fix and it's ready for a final review 🎉

miorsufianiohk · 2020-12-08T10:36:34Z

Hi @DominikGuzei. Here is the report for build 15543.
Note: I have created Test scenarios under 'Test Cases' in this section

Test cases	Results	Note
Scenario 1	Fail	I am still able to see the message "The wallet is empty..". See video build 15543 at 00:05s. However the behaviour was correct on build 15533 See video build 15533
Scenario 2	Pass

nikolaglumac · 2020-12-08T12:10:33Z

source/renderer/app/containers/wallet/WalletUtxoPage.js

@@ -39,6 +39,9 @@ export default class WalletSettingsPage extends Component<Props> {

    return (
      <WalletUtxo
+        isLoadingInitialUtxoData={
+          walletSettings.getWalletUtxosRequest.isExecutingFirstTime


@DominikGuzei shouldn't we make sure we check if this request has been executed for the first time for the active wallet? We fetch UTXO distribution data for each wallet and I am afraid we will have this working only for the first one (or if the user has only one wallet)...
If I remember correctly, it should be possible to pass on walletId to check if the request has been ever executed for the given wallet?

Great catch 👍

@nikolaglumac my latest commit fixes this by resetting the utxo request when leaving the utxo page. This also means that it will show the spinner also anytime you go back to the utxo page within the same wallet. But it's the easiest solution and I think ok since the spinner is rarely showing up anyway - what do you think?

DominikGuzei · 2020-12-09T12:19:41Z

@mioriohk ready for testing again 👍

DominikGuzei · 2020-12-09T12:59:30Z

@mioriohk sorry, I could reproduce the issue from your video and also fixed these edge cases (these have been caused because the loading spinner was only shown when the utxo request has already been made - now it's also shown before the request has been made).

Ready for final test 🎉

miorsufianiohk · 2020-12-10T14:12:05Z

Hi @DominikGuzei. Here is the report for build 15559.
All looks good to me

Test cases	Results	Note
Scenario 1	Pass	Recording for Scenario 1
Scenario 2	Pass	Recording for Scenario 2
Scenario 3	Pass	Recording for Scenario 3
Scenario 4	Pass	Recording for Scenario 4

nikolaglumac · 2020-12-10T18:27:03Z

@mioriohk would you mind approving this PR if it is all good from your side? 🙏

miorsufianiohk

Looks good to me, Well done @DominikGuzei 👍

nikolaglumac

Great work @DominikGuzei 👌

[DDW-492] Add initial loading state to utxo page

fb03fb5

DominikGuzei added the bug label Dec 4, 2020

DominikGuzei self-assigned this Dec 4, 2020

DominikGuzei requested a review from a team December 4, 2020 18:57

DominikGuzei added 2 commits December 4, 2020 20:09

[DDW-492] Add changelog entry

f00f138

[DDW-492] Fix minor flow issue

22fad17

nikolaglumac added the ⏳release-vNext label Dec 7, 2020

nikolaglumac added 3 commits December 7, 2020 10:40

Merge branch 'develop' into fix/ddw-492-wallet-utxo-screen-delay

4b7853d

[DDW-492] Updates CHANGELOG

4d7eb11

[DDW-492] Fixes CHANGELOG

72dc865

DominikGuzei added the WIP label Dec 7, 2020

[DDW-492] Properly handle initial loading request

4d8cd39

DominikGuzei removed the WIP label Dec 7, 2020

nikolaglumac changed the title ~~[DDW-492] Add initial loading state to utxo page~~ [DDW-492] Add initial loading state to UTXO page Dec 8, 2020

nikolaglumac changed the title ~~[DDW-492] Add initial loading state to UTXO page~~ [DDW-492] Add initial loading state to UTXO screen Dec 8, 2020

nikolaglumac requested review from ManusMcCole and miorsufianiohk December 8, 2020 09:54

[DDW-492] Merges develop

51b51f8

nikolaglumac reviewed Dec 8, 2020

View reviewed changes

DominikGuzei added the WIP label Dec 9, 2020

[DDW-492] Reset utxo request when leaving page

fe8d51b

DominikGuzei removed the WIP label Dec 9, 2020

[DDW-492] Show utxo loading state if request hasnt started

92e77ff

miorsufianiohk approved these changes Dec 10, 2020

View reviewed changes

nikolaglumac added 2 commits December 14, 2020 09:36

[DDW-492] Updates CHANGELOG

ba7a790

[DDW-492] Merges develop

59ab4a9

ManusMcCole approved these changes Dec 14, 2020

View reviewed changes

nikolaglumac approved these changes Dec 14, 2020

View reviewed changes

nikolaglumac merged commit 824f9a1 into develop Dec 14, 2020

iohk-bors bot deleted the fix/ddw-492-wallet-utxo-screen-delay branch December 14, 2020 18:33

nikolaglumac added release-3.1.0 Daedalus Mainnet and removed ⏳release-vNext labels Jan 4, 2021

nikolaglumac mentioned this pull request Jan 7, 2021

Merge release/3.1.0 into master #2295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DDW-492] Add initial loading state to UTXO screen #2265

[DDW-492] Add initial loading state to UTXO screen #2265

DominikGuzei commented Dec 4, 2020 •

edited by nikolaglumac

miorsufianiohk commented Dec 7, 2020 •

edited

DominikGuzei commented Dec 7, 2020

miorsufianiohk commented Dec 8, 2020 •

edited

nikolaglumac Dec 8, 2020

DominikGuzei Dec 9, 2020

DominikGuzei Dec 9, 2020

DominikGuzei commented Dec 9, 2020

DominikGuzei commented Dec 9, 2020

miorsufianiohk commented Dec 10, 2020

nikolaglumac commented Dec 10, 2020

miorsufianiohk left a comment

nikolaglumac left a comment

[DDW-492] Add initial loading state to UTXO screen #2265

[DDW-492] Add initial loading state to UTXO screen #2265

Conversation

DominikGuzei commented Dec 4, 2020 • edited by nikolaglumac

Screenshots

Testing Checklist

Test cases

Testing Summary

Review Checklist

Basics

Code Quality

Testing

After Review

miorsufianiohk commented Dec 7, 2020 • edited

DominikGuzei commented Dec 7, 2020

miorsufianiohk commented Dec 8, 2020 • edited

nikolaglumac Dec 8, 2020

Choose a reason for hiding this comment

DominikGuzei Dec 9, 2020

Choose a reason for hiding this comment

DominikGuzei Dec 9, 2020

Choose a reason for hiding this comment

DominikGuzei commented Dec 9, 2020

DominikGuzei commented Dec 9, 2020

miorsufianiohk commented Dec 10, 2020

nikolaglumac commented Dec 10, 2020

miorsufianiohk left a comment

Choose a reason for hiding this comment

nikolaglumac left a comment

Choose a reason for hiding this comment

DominikGuzei commented Dec 4, 2020 •

edited by nikolaglumac

miorsufianiohk commented Dec 7, 2020 •

edited

miorsufianiohk commented Dec 8, 2020 •

edited