New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-503] Show stake pool ID on the "Confirmation" step of the "Delegation" wizard #2281
[DDW-503] Show stake pool ID on the "Confirmation" step of the "Delegation" wizard #2281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @yakovkaravelov 👍
…onfirmation-step-of-the-delegation-wizard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @yakovkaravelov 🎉
This PR updated "Confirmation" step of the "Delegation" wizard to show stake pool ID.
Jira Ticket
Todos
Testing Checklist
App
Staking
=>Stake pools
screenDelegate to this pool
button to openDelegate Wallet
modalContinue
button, select one wallet, and then click onContinue
button 2 times to be atConfirm Delegation
stepStake pool ID
is shown on this stepTest Cases
Scenario 1: Pool id is displayed at last delegation step
Given I have a wallet
And the wallet contains at least the minimum ada required for delegation
And I am on Stake Pool -> Delegation Center
And I have selected (delegate|redelegate) button
And in 'DELEGATE WALLET' dialog I have selected 'Continue'
And in Step 1 of 3 - DELEGATE WALLET I have selected 'Continue'
And in Step 2 of 3 - CHOOSE A STAKE POOL I have selected a pool
When in Step 2 of 3 - CHOOSE A STAKE POOL I select Continue'
Then dialog Step 3 of 3 - CONFIRM DELEGATION is displayed
And pool id is displayed below 'Stake pool ID'
Scenario 2: Able to search pool id in Step 2 delegation step
Given I have a wallet
And the wallet contains at least the minimum ada required for delegation
And I am on Stake Pool -> Delegation Center
And I have selected (delegate|redelegate) button
And in 'DELEGATE WALLET' dialog I have selected 'Continue'
And in Step 1 of 3 - DELEGATE WALLET I have selected 'Continue'
And dialog Step 2 of 3 - CHOOSE A STAKE POOL is displayed
When I search for the 'poolId' in the 'Search stake pools' field
Then the searched pool will be shown underneath the 'Search stake pools' field
<poolId>
the front half of <poolId>
Scenario 3: Able to search pool id in Stake Pool -> Stake pools
Given I am on Stake Pool -> Stake pools
And I am on (tile|list) view
When I search for the 'poolId' in the 'Search stake pools' field
Then the searched pool will be shown underneath the 'Search stake pools' field
<poolId>
the front half of <poolId>
Test Summary
For build 15671:
English
Japanese
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board