Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-503] Show stake pool ID on the "Confirmation" step of the "Delegation" wizard #2281

Conversation

topseniors
Copy link
Contributor

@topseniors topseniors commented Dec 17, 2020

This PR updated "Confirmation" step of the "Delegation" wizard to show stake pool ID.
Jira Ticket

Todos

  • Show stake pool ID on the "Confirmation" step of the "Delegation" wizard
  • Make stake pool ID searchable

Testing Checklist

App

  • Go to Staking => Stake pools screen
  • Try searching stake pool by inputing stake pool id in search field and make sure search is working fine
  • Select one stake pool and click on the Delegate to this pool button to open Delegate Wallet modal
  • Click on Continue button, select one wallet, and then click on Continue button 2 times to be at Confirm Delegation step
  • Make sure Stake pool ID is shown on this step

Test Cases

Scenario 1: Pool id is displayed at last delegation step
Given I have a wallet
And the wallet contains at least the minimum ada required for delegation
And I am on Stake Pool -> Delegation Center
And I have selected (delegate|redelegate) button
And in 'DELEGATE WALLET' dialog I have selected 'Continue'
And in Step 1 of 3 - DELEGATE WALLET I have selected 'Continue'
And in Step 2 of 3 - CHOOSE A STAKE POOL I have selected a pool
When in Step 2 of 3 - CHOOSE A STAKE POOL I select Continue'
Then dialog Step 3 of 3 - CONFIRM DELEGATION is displayed
And pool id is displayed below 'Stake pool ID'

Scenario 2: Able to search pool id in Step 2 delegation step
Given I have a wallet
And the wallet contains at least the minimum ada required for delegation
And I am on Stake Pool -> Delegation Center
And I have selected (delegate|redelegate) button
And in 'DELEGATE WALLET' dialog I have selected 'Continue'
And in Step 1 of 3 - DELEGATE WALLET I have selected 'Continue'
And dialog Step 2 of 3 - CHOOSE A STAKE POOL is displayed
When I search for the 'poolId' in the 'Search stake pools' field
Then the searched pool will be shown underneath the 'Search stake pools' field

poolId
<poolId>
the front half of <poolId>

Scenario 3: Able to search pool id in Stake Pool -> Stake pools
Given I am on Stake Pool -> Stake pools
And I am on (tile|list) view
When I search for the 'poolId' in the 'Search stake pools' field
Then the searched pool will be shown underneath the 'Search stake pools' field

poolId
<poolId>
the front half of <poolId>

Test Summary

For build 15671:

Test cases Results Note
Scenario 1 Pass
Scenario 2 Pass
Scenario 3 Pass

English
image
image

Japanese
image
image

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@topseniors topseniors changed the title [DDW-503]: Show stake pool id on the confirmation step of delegation … [DDW-503] Show stake pool ID on the "Confirmation" step of the "Delegation" wizard Dec 17, 2020
Copy link
Contributor

@DeeJayElly DeeJayElly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @yakovkaravelov 👍

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @yakovkaravelov 🎉

@nikolaglumac nikolaglumac merged commit a163a10 into develop Dec 17, 2020
@iohk-bors iohk-bors bot deleted the chore/ddw-503-show-stake-pool-id-on-the-confirmation-step-of-the-delegation-wizard branch December 17, 2020 19:49
@nikolaglumac nikolaglumac added release-3.1.0 Daedalus Mainnet and removed ⏳release-vNext labels Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-3.1.0 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants