New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-501] Hide copy and paste context menu items on some scenarios #2300
[DDW-501] Hide copy and paste context menu items on some scenarios #2300
Conversation
@nikolaglumac @gnpf @mioriohk @ManusMcCole @DeeJayElly This is ready for review/test. |
Hi @yakovkaravelov. Tested on build 15864
|
@ManusMcCole Automatic selection of text is not a bug. |
@yakovkaravelov All scenarios passed on build 15867 when tested on Linux. Will continue on Windows/Mac tomorrow. |
@yakovkaravelov please post screenshots from the installer as there we do not show the "inspect" item. |
@yakovkaravelov All scenarios passed on build 15867 when tested on Windows/Mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix @yakovkaravelov 💯
This PR hided copy and paste context menu items on some scenarios
Jira Ticket
Todos
Testing Checklist
App
Test Cases
Scenario 1:
Given that I have a Shelley wallet fully synced
And the wallet has transactions
And I am on the transactions Tab
And I navigate to a recieved transaction
When I right click on the text "Open this transaction in Cardano Explorer" with no text highlighted
Then the tooltip text should have no copy and paste options present
Scenario 2:
Given that I have a Shelley wallet fully synced
And the wallet has transactions
And I am on the transactions Tab
And I navigate to a received transaction
And I highlight the text "addresses" in the From Address section
When I right click/control click on the text "addresses" with the text highlighted
Then I should see the tooltip display the options "copy" only
Scenario 3:
Given that I have a Shelley wallet fully synced
And I am on the Send Tab
And the wallet has transactions
And I highlight the address in the receiver box
And I have text/numeric input copied to my clipboard
When I right click/control click on the highlighted receiver address text
Then the tooltip should display the options "Copy" and "Paste"
Scenario 4:
Given that I have a Shelley wallet fully synced
And I am on the Send Tab
And the wallet has transactions
And I highlight the address in the receiver box
And my clipboard is empty
When I right click/control click on the highlighted receiver address text
Then the tooltip should display the options "Copy" only
Scenario 5:
Given that I have a Shelley wallet fully synced
And the wallet has transactions
And I am on the Summary Tab
When I right click/control click on the wallet balance with no text highlighted
Then the tooltip text should not have "copy" or "paste" options available
Scenario 6:
Given that I have a Shelley wallet fully synced
And the wallet has transactions
And I am on the Summary Tab
When I right click/control click on the wallet balance with all of the wallet balance text highlighted
Then the tooltip text should read "copy" with no paste option available
Scenario 7:
Given that I have the node fully synced
And I am on the stake pools screen
And I click on a stake pool to open the stake pool information popup
Then if there is no text highlighted
And I right click/control click
Then the "copy" and "paste" option is not visible
Scenario 8:
Given that I have the node fully synced
And I am on the stake pools screen
And I click on a stake pool to open the stake pool information popup
And I highlight some text
And there is no input box present
And I right click/control click
Then the paste option should not be visible
And the "copy" option is visible
Testing Summary
English
Japanese
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board