New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-566] Implement "Voting registration is over" screen #2428
[DDW-566] Implement "Voting registration is over" screen #2428
Conversation
@alexander-rukin, check the fonts, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-rukin, check the fonts, please.
"Fund3 FAQs" should use font-regular (now font-medium) + it's for no reason in a smaller font size (14 -> should be 16)
rest seems ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
@yakovkaravelov please add Japanese translations 🙏 |
This PR implemented "Voting registration is over" screen.
Jira Ticket
Todos
Testing Checklist
App
Voting
and make sure "Voting registration is over" screen is shown when registration period was already endedScreenshots
English
Japanese
In Progress...
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board