Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-566] Implement "Voting registration is over" screen #2428

Merged

Conversation

topseniors
Copy link
Contributor

This PR implemented "Voting registration is over" screen.
Jira Ticket

Todos

  • Implement "Voting registration is over" screen

Testing Checklist

App

  • Go to Voting and make sure "Voting registration is over" screen is shown when registration period was already ended

Screenshots

English

image

Japanese

In Progress...

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@darko-mijic
Copy link
Contributor

@alexander-rukin, check the fonts, please.

@alexander-rukin alexander-rukin self-requested a review March 3, 2021 12:53
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-rukin, check the fonts, please.

image

"Fund3 FAQs" should use font-regular (now font-medium) + it's for no reason in a smaller font size (14 -> should be 16)
rest seems ok

@alexander-rukin
Copy link
Contributor

image

margin-bottom should be 11px

@topseniors topseniors removed the WIP label Mar 3, 2021
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@nikolaglumac
Copy link
Contributor

@yakovkaravelov please add Japanese translations 🙏

@nikolaglumac nikolaglumac merged commit 49bbd5f into release/3.3.2 Mar 3, 2021
@iohk-bors iohk-bors bot deleted the feature/ddw-566-voting-registration-is-over-screen branch March 3, 2021 15:29
@nikolaglumac nikolaglumac added the release-4.0.1-FC2 Daedalus Flight label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-3.3.2 Daedalus Mainnet release-4.0.1-FC2 Daedalus Flight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants