[DDW-570] Update "View wallet's public key" feature #2429

thedanheller · 2021-03-03T16:26:52Z

This PR updates the "View wallet's public key" feature.

Todos

Re-enable functionality in the constant variable
Implement the password dialog
Change the field logic to trigger the dialog
Update the API request
Enable "view wallet's public key" option for HW
Show HW public keys in bech32 format

Screenshots

Testing Checklist

Slack QA thread
Test

Test Cases

Scenario 1: Reveal spending password textfield
Given I am on <wallet_type> wallet
When I select reveal button
Then a dialog box appears
And it displays spending password textfield

|wallet_type|
|shelley|


Scenario 2: Reveal public key first time
Given I am on <wallet_type> wallet
And I have correctly entered spending password
When I select reveal wallet public key button
Then wallet public key is displayed in textfield

|wallet_type|
|shelley|


Scenario 3: Reveal public key after successfully displayed the first time
Given I am on <wallet_type> wallet
When I select reveal button
Then the public key is displayed in the textfield

|wallet_type|
|shelley|

Scenario 4: Copy public key
Given public key is displayed in the textfield
When I select copy button
Then public key is copied
And can be pasted correctly

Scenario 5: Show QR code
Given public key is displayed in the textfield
When I select show QR code
Then QR code dialog box is displayed
And wallet public key is displayed

Scenario 6: Hide public key
Given public key is displayed in the textfield
When I select hide button
Then public key is hidden

Scenario 7: Reveal public key after hidden
Given public key is hidden
When I select reveal button
Then public key is displayed in textfield


Scenario 8: Reveal public key first time for hardware wallet
Given I am on hardware wallet
When I select reveal wallet public key button
Then wallet public key is displayed in textfield

Review Checklist

Basics

Code Quality

Important parts of the code are properly commented and documented
Code is properly typed with flow
React components are split-up enough to avoid unnecessary re-renderings
Any code that only works in main process is neatly separated from components

Testing

New feature/change is covered by acceptance tests
New feature/change is manually tested and approved by QA team
All existing acceptance tests are still up-to-date
New feature/change is covered by Daedalus Testing scenario
All existing Daedalus Testing scenarios are still up-to-date

After Review

Merge the PR
Delete the source branch
Move the ticket to done column on the YouTrack board
Update Slack QA thread by marking it with a green checkmark

…c-key-feature

…n false

…n true

source/renderer/app/api/wallets/requests/getWalletPublicKey.js

source/renderer/app/stores/WalletsStore.js

…c-key-feature # Conflicts: # CHANGELOG.md

…tPublicKey and adding getAccountPublicKey

…c-key-feature

… from hex to bech32

… of github.com:input-output-hk/daedalus into feature/ddw-570-update-view-wallets-public-key-feature

tomislavhoracek · 2021-03-09T16:58:05Z

@daniloprates @nikolaglumac Support for Hardware Wallets public key improved. Now we have bech32 format for HW xpub.

darko-mijic · 2021-03-09T17:25:46Z

Reviewing this now...

darko-mijic · 2021-03-09T17:30:40Z

Reveal public key should open the popup for hardware wallets as for software wallets.

darko-mijic · 2021-03-09T17:39:07Z

Strike my previous comment. We should not be opening the window with the QR code for sw wallets. Remove that, please.

alexander-rukin

Looks good to me

nikolaglumac · 2021-03-09T18:01:17Z

Strike my previous comment. We should not be opening the window with the QR code for sw wallets. Remove that, please.

Done!

miorsufianiohk

LGTM. Great job @nikolaglumac 👍

Found issues

gabriela-ponce · 2021-03-09T18:35:35Z

@daniloprates I found these issues on 17048:

When syncing hardware wallets a password is requested to reveal the public key. Check this video.
If you insert a short password the message reads "An error occurred" instead of "Incorrect wallet password". Check this video.

nikolaglumac · 2021-03-10T09:57:25Z

@gabriela-ponce @miorsufianiohk @darko-mijic all issues fixed!

miorsufianiohk

Hi @daniloprates . On 17052 I have narrowed down the issue that we are facing with spending password dialog box for hw wallet. cc: @nikolaglumac

I found this:

For HW wallet, when I pressed reveal button (Result: Spending password dialog box displayed)
I dismissed the spending password dialog box
Then, I went to SW wallet, pressed reveal button (Result: Spending password dialog box displayed)
I dismissed the spending password dialog box
I went back to HW wallet and pressed reveal button (Result: no spending dialog box displayed anymore and public key is populated in textfield)
After this going back and forth SW and HW wallets, don't make HW wallets spending password dialog to come up again.

For further info please watch video

nikolaglumac · 2021-03-10T09:59:28Z

@miorsufianiohk all these issues have just been fixed.

miorsufianiohk

LGTM. Great job @nikolaglumac 👍 . Tested on 17055

[DDW-570] UI part

94ff533

thedanheller added feature WIP ⏳release-vNext labels Mar 3, 2021

thedanheller self-assigned this Mar 3, 2021

thedanheller added 4 commits March 3, 2021 13:27

[DDW-570] CHANGELOG

d51fd48

[DDW-570] Api implementation

6de3476

[DDW-570] Simplify code

62d26a1

[DDW-570] Translation manager

fd94b14

thedanheller removed the WIP label Mar 3, 2021

thedanheller added 3 commits March 3, 2021 18:09

[DDW-570] Code improvements

2688107

[DDW-570] Code improvements

e47e24f

[DDW-570] Code improvements

25459b3

nikolaglumac assigned DeeJayElly Mar 4, 2021

nikolaglumac added 2 commits March 4, 2021 09:30

Merge branch 'develop' into feature/ddw-570-update-view-wallets-publi…

a3d7d25

…c-key-feature

[DDW-570] Updates CHANGELOG

0cce2a8

nikolaglumac added the WIP label Mar 4, 2021

DeeJayElly added 2 commits March 4, 2021 04:15

DDW-570 - Update view wallets public key feature - setting extended o…

1b5e13a

…n false

DDW-570 - Update view wallets public key feature - setting extended o…

4ff5743

…n true

nikolaglumac suggested changes Mar 4, 2021

View reviewed changes

source/renderer/app/api/wallets/requests/getWalletPublicKey.js Outdated Show resolved Hide resolved

nikolaglumac reviewed Mar 4, 2021

View reviewed changes

source/renderer/app/stores/WalletsStore.js Outdated Show resolved Hide resolved

nikolaglumac reviewed Mar 4, 2021

View reviewed changes

source/renderer/app/stores/WalletsStore.js Outdated Show resolved Hide resolved

nikolaglumac reviewed Mar 4, 2021

View reviewed changes

source/renderer/app/stores/WalletsStore.js Outdated Show resolved Hide resolved

nikolaglumac reviewed Mar 4, 2021

View reviewed changes

source/renderer/app/stores/WalletsStore.js Outdated Show resolved Hide resolved

DeeJayElly added 4 commits March 4, 2021 11:13

DDW-570 - Update view wallets public key feature - setting index

cf01c25

Merge branch 'develop' into feature/ddw-570-update-view-wallets-publi…

cfea9b3

…c-key-feature # Conflicts: # CHANGELOG.md

DDW-570 - Update view wallets public key feature - reverting getWalle…

d59257a

…tPublicKey and adding getAccountPublicKey

DDW-570 - Tile view of stake pools ranked by rewards - linter

efa9f35

DeeJayElly requested a review from nikolaglumac March 5, 2021 08:28

Merge branch 'develop' into feature/ddw-570-update-view-wallets-publi…

3def7cb

…c-key-feature

Tomislav Horaček added 2 commits March 9, 2021 17:55

[DDW-570] Introduce a logic for formatting hardware wallet public key…

18d4cfb

… from hex to bech32

Merge branch 'feature/ddw-570-update-view-wallets-public-key-feature'…

0fdc4b9

… of github.com:input-output-hk/daedalus into feature/ddw-570-update-view-wallets-public-key-feature

nikolaglumac removed the WIP label Mar 9, 2021

[DDW-570] Updates yarn.lock, Adds return types

f1591ec

nikolaglumac approved these changes Mar 9, 2021

View reviewed changes

nikolaglumac requested a review from alexander-rukin March 9, 2021 17:11

nikolaglumac unassigned tomislavhoracek Mar 9, 2021

alexander-rukin approved these changes Mar 9, 2021

View reviewed changes

[DDW-570] Removes automatic display of QR code dialog

03b17ec

miorsufianiohk previously approved these changes Mar 9, 2021

View reviewed changes

nikolaglumac added 2 commits March 9, 2021 20:04

[DDW-570] Fix short password error message

69bb782

[DDW-570] Fix HW race conditions

c947dab

miorsufianiohk requested changes Mar 10, 2021

View reviewed changes

nikolaglumac requested a review from miorsufianiohk March 10, 2021 10:03

miorsufianiohk approved these changes Mar 10, 2021

View reviewed changes

nikolaglumac merged commit a175cb0 into develop Mar 10, 2021

iohk-bors bot deleted the feature/ddw-570-update-view-wallets-public-key-feature branch March 10, 2021 10:20

nikolaglumac added release-4.0.2-FC3 Daedalus Flight and removed ⏳release-vNext labels Mar 15, 2021

nikolaglumac mentioned this pull request Mar 15, 2021

Support Export of xPub Key #2345

Closed

nikolaglumac mentioned this pull request Mar 30, 2021

Merge release/4.0.3 into master #2491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DDW-570] Update "View wallet's public key" feature #2429

[DDW-570] Update "View wallet's public key" feature #2429

thedanheller commented Mar 3, 2021 •

edited by miorsufianiohk

tomislavhoracek commented Mar 9, 2021 •

edited

darko-mijic commented Mar 9, 2021

darko-mijic commented Mar 9, 2021

darko-mijic commented Mar 9, 2021

alexander-rukin left a comment

nikolaglumac commented Mar 9, 2021

miorsufianiohk left a comment

gabriela-ponce commented Mar 9, 2021

nikolaglumac commented Mar 10, 2021

miorsufianiohk left a comment •

edited

nikolaglumac commented Mar 10, 2021

miorsufianiohk left a comment

[DDW-570] Update "View wallet's public key" feature #2429

[DDW-570] Update "View wallet's public key" feature #2429

Conversation

thedanheller commented Mar 3, 2021 • edited by miorsufianiohk

Todos

Screenshots

Testing Checklist

Test Cases

Review Checklist

Basics

Code Quality

Testing

After Review

tomislavhoracek commented Mar 9, 2021 • edited

darko-mijic commented Mar 9, 2021

darko-mijic commented Mar 9, 2021

darko-mijic commented Mar 9, 2021

alexander-rukin left a comment

Choose a reason for hiding this comment

nikolaglumac commented Mar 9, 2021

miorsufianiohk left a comment

Choose a reason for hiding this comment

gabriela-ponce commented Mar 9, 2021

nikolaglumac commented Mar 10, 2021

miorsufianiohk left a comment • edited

Choose a reason for hiding this comment

nikolaglumac commented Mar 10, 2021

miorsufianiohk left a comment

Choose a reason for hiding this comment

thedanheller commented Mar 3, 2021 •

edited by miorsufianiohk

tomislavhoracek commented Mar 9, 2021 •

edited

miorsufianiohk left a comment •

edited