Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-624] Update trezor-connect dependency to version 8.1.25 #2474

Merged
merged 2 commits into from Mar 25, 2021

Conversation

tomislavhoracek
Copy link
Contributor

This PR introduces trezor-connect dependency update to the version 8.1.25.
This version should include a fix for Trezor Passphrase handling mentioned in trezor/connect#783


Testing Checklist

Dedicated QA: @ManusMcCole

  • Slack QA thread
  • Try to reproduce a known Trezor issue when the user is not prompted to enter a passphrase on the device and instead of that "Please type your passphrase on the connected host" is shown.
  • Try to restore a Trezor HW, send TX and delegate. We need to ensure that package version update is working properly for all Trezor scenarios.

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@ManusMcCole
Copy link

ManusMcCole commented Mar 24, 2021

Hi Tomislav. Here is the testing report for Testnet build 17262. No other devices were connected to the USB apart from Trezor throughout the whole testing process.

On Windows only.On the first round of testing the Device paired and I was able to restore a Trezor wallet with a blank passphrase(Wallet 1) and (Wallet2). The functionality worked as expected until I tried to delete the wallets and I got this Error . I had successfully confirmed 2 transactions before attempting to delete wallet and the device remained plugged in.Wallets froze up when I tried to delete. Upon Daedalus restart I was able to delete the wallet successfully

On Windows only.On round 2 and 3, 4 of testing(I deleted the state directory and Daedalus was uninstalled in between each round) I was not even able to pair my Trezor device at all. There were no errors in the console and Windows was making the correct sound to show it recognized a device was plugged in. It is stuck on the "Connect your device and enter your pin to unlock it" device no matter what steps I use before pairing

@nikolaglumac
Copy link
Contributor

Hi Tomislav. Here is the testing report for Testnet build 17262. No other devices were connected to the USB apart from Trezor throughout the whole testing process.

On Windows only.On the first round of testing the Device paired and I was able to restore a Trezor wallet with a blank passphrase(Wallet 1) and (Wallet2). The functionality worked as expected until I tried to delete the wallets and I got this Error . I had successfully confirmed 2 transactions before attempting to delete wallet and the device remained plugged in.Wallets froze up when I tried to delete. Upon Daedalus restart I was able to delete the wallet successfully

@ManusMcCole this looks to me like an unrelated CWB error. I have started a thread on Slack for this one...

Copy link

@ManusMcCole ManusMcCole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tomislavhoracek 👍

@nikolaglumac nikolaglumac merged commit 81e7e7d into develop Mar 25, 2021
@iohk-bors iohk-bors bot deleted the chore/ddw-624-update-trezor-connect-dependency branch March 25, 2021 08:36
@nikolaglumac nikolaglumac added release-4.0.3 Daedalus Mainnet and removed ⏳release-vNext labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-4.0.3 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants