Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-621] Improve currency Japanese translations #2497

Merged

Conversation

thedanheller
Copy link
Member

@thedanheller thedanheller commented Apr 1, 2021

This PR CHANGES.

Todos

  • Add the ja key to the currencies JSON list
  • Change the code to use the en/ja keys instead of name
  • Add the Japanese translation - (Junko)

Screenshots

Screen Shot 2021-04-09 at 16 26 46
Screen Shot 2021-04-09 at 16 26 50


Testing Checklist


Testing scenarios

Scenario 1 - Check currencies according to language

Given that Daedalus selected language is |English/Japanese|
And I am on the "Wallets" screen from "Settings"
And the option of show balance in other currencies is enabled
When I check the names of the currencies in the dropdown
Then I can see that the names are displayed in the selected language

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@thedanheller thedanheller removed the WIP label Apr 9, 2021
@thedanheller thedanheller requested a review from a team April 9, 2021 19:52
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Tested on 17573.

Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniloprates Please fix CHANGELOG and improve PR description.
Other changes are good!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nikolaglumac nikolaglumac merged commit 6dfd02d into develop Apr 13, 2021
@iohk-bors iohk-bors bot deleted the feature/ddw-621-improve-currency-japanese-translations branch April 13, 2021 12:06
@nikolaglumac nikolaglumac added the release-4.0.5 Daedalus Mainnet label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-4.0.5 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants