New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-453] Earned delegation rewards "export CSV" button update styles #2509
[DDW-453] Earned delegation rewards "export CSV" button update styles #2509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yakovkaravelov , @alexander-rukin found issues with scrolling start/end position on build 17528. See video here
…xport-csv-button-update-styles
@miorsufianiohk @tomislavhoracek @alexander-rukin Please review/test. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Tested on 17541
…xport-csv-button-update-styles
This PR updated header section styles of delegation rewards screen so that header section gets sticky when scrolling content section
Jira Ticket
Todos
Testing Checklist
Test Cases
App
Staking
=>Rewards
and make sure header section gets sticky when scrolling content sectionScreenshots
English
Japanese
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board