New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-639] Fund5 voting registration with Ledger #2538
Merged
nikolaglumac
merged 26 commits into
develop
from
feature/ddw-639-fund5-voting-registration-with-ledger
Jul 6, 2021
Merged
[DDW-639] Fund5 voting registration with Ledger #2538
nikolaglumac
merged 26 commits into
develop
from
feature/ddw-639-fund5-voting-registration-with-ledger
Jul 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…net for testing purpose
37 tasks
… mixing with previous active wallet from sidebar
tomislavhoracek
requested review from
DeeJayElly,
a team,
ManusMcCole and
miorsufianiohk
July 5, 2021 14:35
ManusMcCole
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @tomislavhoracek 👍
miorsufianiohk
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on Nano X. Tested on Mac, Linux and Windows on build 18498. Great work @tomislavhoracek 👍
nikolaglumac
approved these changes
Jul 6, 2021
iohk-bors
bot
deleted the
feature/ddw-639-fund5-voting-registration-with-ledger
branch
July 6, 2021 12:45
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Introduces Catalyst voting registration with Ledger devices
Todos
any
declarationVoting registration CWB bug and related threads:
https://jira.iohk.io/browse/ADP-1005
https://input-output-rnd.slack.com/archives/GGKHNC5V4/p1623929752061200
https://input-output-rnd.slack.com/archives/C819S481Y/p1623941347111200
Testing Checklist
Screenshots
English
Japanese
##Test Cases
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board