[DDW-635] Fix pool description scrolling and styling #2564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pool description scrolling (which is currently broken) + styling issues (some words overflowing on the right side if there is no scroll bars).
Details of the fix:
The issue was caused by the feature that the stake pool pop overs are hidden on scrolling because the scroll event listener was added to the
window
which resulted in any scrolling to hide the popovers (also when scrolling the pool description).In addition I fixed a styling issue with pool descriptions that are long enough to span multiple lines but do not trigger a scrollbar yet - @dmitrii-gaico reported that in some cases words overflowed the right edge … this was caused by the negative margin which was added to align the scrollbar but padding-right was missing to keep the text inside correctly.
Testing Checklist
Test Cases
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board