Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-635] Fix pool description scrolling and styling #2564

Merged

Conversation

DominikGuzei
Copy link
Member

@DominikGuzei DominikGuzei commented May 14, 2021

This PR fixes the pool description scrolling (which is currently broken) + styling issues (some words overflowing on the right side if there is no scroll bars).

Details of the fix:
The issue was caused by the feature that the stake pool pop overs are hidden on scrolling because the scroll event listener was added to the window which resulted in any scrolling to hide the popovers (also when scrolling the pool description).

In addition I fixed a styling issue with pool descriptions that are long enough to span multiple lines but do not trigger a scrollbar yet - @dmitrii-gaico reported that in some cases words overflowed the right edge … this was caused by the negative margin which was added to align the scrollbar but padding-right was missing to keep the text inside correctly.


Testing Checklist

  • Slack QA thread
  • Test that stake pools with long description can be scrolled via mouse wheel & scroll handle
  • Check that no words are overflowing too far to the right on longer pool descriptions that do not show a scroll bar

Test Cases

Scenario 1: Scrolling works as expected and popup remains open
Given I am on Staking Center->Stake pools
And I select a pool with long description
And the popup has scrollbar next to description
When I attempt to scroll the description
Then the description will scroll up and down
And the popup will remain open

Scenario 2: Pool description doesn't overflow
Given I am on Staking Center->Stake pools
And I select a pool with long description
When I observe the description
Then the description is displayed correctly
And the description is aligned with other elements

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@DominikGuzei DominikGuzei self-assigned this May 14, 2021
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @DominikGuzei . Tested on all 3 platforms on build 17980. 👍

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DominikGuzei 💯

@nikolaglumac nikolaglumac merged commit ae4955e into develop May 14, 2021
@iohk-bors iohk-bors bot deleted the fix/ddw-635-unable-to-scrool-stake-pool-description branch May 14, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants