New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-667] Use token decimal places info from the cardano-wallet Api #2577
[DDW-667] Use token decimal places info from the cardano-wallet Api #2577
Conversation
Shouldn't we highlight the currently selected option ? For now we always highlight the Default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
We should discuss it and fix it in a separate ticket. This may be a UX improvement for the whole app. |
That's not a part of this PR. |
@daniloprates I have merged this one but would still appreciate if you could take a look at it... |
This PR integrates token decimal places info from the cardano-wallet Api.
Todos
v2021-05-26
Show zero balance tokens on the summary screen too[Will be done in a separate card: https://jira.iohk.io/browse/DDW-694]Screenshots
Testing Checklist
Test Scenarios
Scenario 1 - Check recommended precision is preselected on settings
Scenario 2 - Check selected precision is persisted on settings
Scenario 3 - Check default precision is preselected on settings
Scenario 4 - Check selected precision is persisted on settings
Scenario 5 - Check the token metadata is persisted if the API doesn't return data
Scenario 6 - Check the token metadata is persisted after restart if the API doesn't return data
Scenario 7 - Check Save button is disabled
Scenario 8 - Check Save button is enabled
Scenario 9 - Check new precision is saved
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board