Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-561] Fix crashes when Yubikey is connected #2673

Merged
merged 8 commits into from Sep 17, 2021
Merged

[DDW-561] Fix crashes when Yubikey is connected #2673

merged 8 commits into from Sep 17, 2021

Conversation

danielmain
Copy link
Contributor

@danielmain danielmain commented Sep 15, 2021 •
edited

This PR fixes a crash happening when a smart card / yubikey is inserted when Daedalus is running in Windows 10

Todos

  • Patch usb library and recompile for Windows
  • Create new nix/windows-usb-libs.zip

Testing Checklist

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Update Slack QA thread by marking it with a green checkmark

@danielmain
Copy link
Contributor Author

This is a patch by fixing this Issue node-usb/node-usb#386
TODO: watch https://github.com/tessel/node-usb if they fix it, so we do not need to use the patched version anymore.

@miorsufianiohk
Copy link

@danielmain ,

I have tested build 19071 Windows Mainnet/Testnet against Yubikey + HWs. Looked good. No crashes anymore. Also, tested against Mac/Linux just in case. Also looked good 👍 .

Before approving, could other QAs help to double check just in case please, thanks. cc: @ManusMcCole @dmitrii-gaico

miorsufianiohk
miorsufianiohk approved these changes Sep 16, 2021
View reviewed changes
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested agains 19071 👍

nikolaglumac
nikolaglumac suggested changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix @danielmain!
There is just one tiny comment I have left...

CHANGELOG.md Outdated Show resolved Hide resolved
nikolaglumac
nikolaglumac approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! 💯

@nikolaglumac nikolaglumac merged commit 54429c8 into develop Sep 17, 2021
@iohk-bors iohk-bors bot deleted the fix/ddw-561-fix-usb-crash branch September 17, 2021 06:52
@nikolaglumac nikolaglumac mentioned this pull request Sep 20, 2021
Open
@nikolaglumac nikolaglumac added release-4.3.2 Daedalus Mainnet and removed ⏳release-vNext labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaglumac nikolaglumac nikolaglumac approved these changes

@miorsufianiohk miorsufianiohk miorsufianiohk approved these changes

@dmitrii-gaico dmitrii-gaico dmitrii-gaico approved these changes

Assignees

@danielmain danielmain

Labels
bug release-4.3.2 Daedalus Mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielmain @miorsufianiohk @nikolaglumac @dmitrii-gaico