Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-680] Small UI/UX fixes #2685

Merged
merged 130 commits into from Nov 4, 2021
Merged

Conversation

mchappell
Copy link
Contributor

@mchappell mchappell commented Sep 28, 2021

This PR makes a number of small UI/UX across the Daedalus application

Todos

  • Stake pool tooltip should say 'Copied' while checkmark confirmation is visible
  • Padding for share wallet adjusted
  • 'Back to top' button in stake pool list should only appear after first row of pools is over scrolled
  • Countdown elements should always fit on one line
  • Staking pools copy adjusted
  • Blocks synced tooltip matches design of other tooltips
  • Wallet name should always fit on a single line, trimmed with '...'
  • Disabled state for red checkbox in send dialog has 0.3 opacity
  • 'Copy address' should have hover effect for text and icon
  • Confirm transaction address uses 100% opacity
  • Hover effect for wallet public key triggers hover state for copy button
  • Make progress bars animation consistent
  • Align delegation center loading spinners to right of container
  • Align wallet recovery step indicators
  • Adjust font for off-chain pool information
  • Increase drop shadow in staking pools cards
  • Change wallet restoration text
  • Show newly restored wallets immediately in wallet list
  • Adjust distance between name and balance in delegation center
  • Adjust font color for recovery phrase indicator of redemption rewards
  • Adjust close icon vertical centering
  • Center arrow icon of token dropdown
  • Remove spacing after last row in delegation center
  • Center undelegated text in stake pool card
  • Only show CoinGecko info message if currencies have loaded
  • Vertically center "redelegate" button text in staking card
  • For empty wallets disable filter button
  • Clear all text if selected and typing in send dialog
  • Move hardware wallet disconnect message inside text field
  • Remove scrollbar in asset name popover
  • Saturation progress bar fixed width
  • Adjust colored line in stakepool tile
  • Correct 'cardano' and 'lightBlue' theming for software update 'x' button
  • Correct 'cardano' and 'lightBlue' theming for cardano node status 'x' button and scrollbar color
  • Update line-height for wallet creation/restore/import/HW buttons
  • Update padding in restore wallet dialog stepper
  • Update font used for staking pool tiles
  • Update font used for staking pools headings
  • Update positioning of 'back to top' button in stake pools delegation dialog
  • Update disabled select in redeem dialog
  • Fix glow effect in stake pools delegate dialog
  • Fix alignment of loading indicator in estimated fees input

Screenshots

  • Screenshot

Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@mchappell mchappell removed the WIP label Nov 2, 2021
@gabriela-ponce
Copy link

@mchappell I reviewed the document and the previous issues again and almost everything is fixed, great job.

There are a few that still reproduce and some to be discussed with @alexander-rukin .
I updated the document and we can have a call tomorrow to check those.
Here's an issue that's not included in the document that still reproduces:

  • The tooltip for unformatted values of Native tokens looks wrong with big numbers. Check this and this screenshot (on the last one, there is no space between the : and the number).

@alexander-rukin
Copy link
Contributor

  • The tooltip for unformatted values of Native tokens looks wrong with big numbers. Check this and this screenshot (on the last one, there is no space between the : and the number).

Added this issue to the next doc

@mchappell
Copy link
Contributor Author

@mchappell I reviewed the document and the previous issues again and almost everything is fixed, great job.

There are a few that still reproduce and some to be discussed with @alexander-rukin . I updated the document and we can have a call tomorrow to check those. Here's an issue that's not included in the document that still reproduces:

  • The tooltip for unformatted values of Native tokens looks wrong with big numbers. Check this and this screenshot (on the last one, there is no space between the : and the number).

Unformatted values native token moved to DDW-807

Copy link

@gabriela-ponce gabriela-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎉

@dmitrii-gaico dmitrii-gaico self-requested a review November 4, 2021 08:23
@nikolaglumac nikolaglumac merged commit 714306b into develop Nov 4, 2021
@iohk-bors iohk-bors bot deleted the fix/ddw-680-small-ui-ux-fixes branch November 4, 2021 08:52
@nikolaglumac nikolaglumac added release-4.5.0 Daedalus Mainnet and removed ⏳release-vNext labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-4.5.0 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants