Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-747] Fix transaction localization #2702

Merged
merged 4 commits into from Oct 18, 2021

Conversation

mchappell
Copy link
Contributor

@mchappell mchappell commented Oct 11, 2021

This PR immediately localizes transaction timestamps when settings language is changed

Todos

  • localize transaction timestamp

Screenshots

transaction.locale.fix.mov

Testing Checklist


Test Scenarios

Scenario 1 - Validate transactions after switching to Japanese

Given that Daedalus is synced
And it has a synced wallet with transaction history
And the selected language is English
And the time format is 12 hs with AM/PM indicators
When I switch the language to Japanese
And I check the timestamp of a transaction without reloading Daedalus
Then I can see that the corresponding "AM/PM" translations are displayed next to the time

Scenario 2 - Validate transactions after switching to English

Given that Daedalus is synced
And it has a synced wallet with transaction history
And the selected language is Japanese
And the time format is 12 hs with AM/PM indicators
When I switch the language to English
And I check the timestamp of a transaction without reloading Daedalus
Then I can see that the "AM/PM" indicator is displayed next to the time

Scenario 3 - Validate transactions after switching time indicators (English)

Given that Daedalus is synced
And it has a synced wallet with transaction history
And the selected language is Japanese
And the time format is 24 hs without AM/PM indicators
When I switch the language to English
And change the time format to include AM/PM indicators
And I check the timestamp of a transaction without reloading Daedalus
Then I can see that the "AM/PM" indicator is displayed next to the time

Scenario 4 - Validate transactions after switching time indicators (Japanese)

Given that Daedalus is synced
And it has a synced wallet with transaction history
And the selected language is English
And the time format is 24 hs without AM/PM indicators
When I switch the language to Japanese
And change the time format to include AM/PM indicators
And I check the timestamp of a transaction without reloading Daedalus
Then I can see that the corresponding "AM/PM" translations are displayed next to the time

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchappell 💯

Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Tested on 19277. Great work @mchappell

@nikolaglumac nikolaglumac changed the title [DDW-747] fix: transaction localization [DDW-747] Fix transaction localization Oct 18, 2021
@nikolaglumac nikolaglumac merged commit a093ae3 into develop Oct 18, 2021
@iohk-bors iohk-bors bot deleted the fix/ddw-747-translate-transaction-timestamp branch October 18, 2021 11:16
@nikolaglumac nikolaglumac added release-4.5.0 Daedalus Mainnet and removed ⏳release-vNext labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-4.5.0 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants