New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-749] Remove Alonzo tada icon and countdown screen #2708
[DDW-749] Remove Alonzo tada icon and countdown screen #2708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @mchappell just a few details
…tps://github.com/input-output-hk/daedalus into feature/ddw-749-remove-alonzo-tada-and-countdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Tested on 19312. Great work @mchappell .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mchappell 👌
This PR
Todos
Screenshots
Testing Checklist
Test Scenarios
Scenario 1 - Validate the "tada" icon is not visible while syncing
Scenario 2 - Validate the "tada" is not visible when Daedalus is synced
Note: Use
daedalus.api.ada.getNetworkParameters()
to get the starting epochs for all the eras.Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board