Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-749] Remove Alonzo tada icon and countdown screen #2708

Merged
merged 15 commits into from Oct 18, 2021

Conversation

mchappell
Copy link
Contributor

@mchappell mchappell commented Oct 14, 2021

This PR

  • Removes the 'tada' button from the top navigation
  • Removes Staking info screen from staking navigation
  • Hides the Staking info screen and routing behind a configuration property

Todos

  • Remove the 'tada' button from the top navigation
  • Remove Staking info screen from staking navigation
  • Hide the Staking info screen and routing behind a configuration property

Screenshots

image


Testing Checklist


Test Scenarios

Scenario 1 - Validate the "tada" icon is not visible while syncing

Given that Daedalus is syncing
And the syncing progress has reached the Alonzo era epoch
When I check the top bar
Then I can see that no "tada" icon is displayed

Scenario 2 - Validate the "tada" is not visible when Daedalus is synced

Given that Daedalus is synced
When I check the top bar
Then I can see that no "tada" icon is displayed
And on "Staking center" the "info" tab is no longer visible

Note: Use daedalus.api.ada.getNetworkParameters() to get the starting epochs for all the eras.


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mchappell just a few details

source/renderer/app/containers/staking/Staking.js Outdated Show resolved Hide resolved
source/renderer/app/containers/TopBarContainer.js Outdated Show resolved Hide resolved
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Tested on 19312. Great work @mchappell .

@nikolaglumac nikolaglumac changed the title Feature/ddw 749 remove alonzo tada and countdown [DDW-749[ Remove Alonzo tada icon and countdown screen Oct 18, 2021
@nikolaglumac nikolaglumac changed the title [DDW-749[ Remove Alonzo tada icon and countdown screen [DDW-749] Remove Alonzo tada icon and countdown screen Oct 18, 2021
@nikolaglumac nikolaglumac self-requested a review October 18, 2021 14:52
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mchappell 👌

@nikolaglumac nikolaglumac merged commit 98bebf5 into develop Oct 18, 2021
@iohk-bors iohk-bors bot deleted the feature/ddw-749-remove-alonzo-tada-and-countdown branch October 18, 2021 14:55
@nikolaglumac nikolaglumac added release-4.5.0 Daedalus Mainnet and removed ⏳release-vNext labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-4.5.0 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants