New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-780] Daedalus start impovement #2716
[DDW-780] Daedalus start impovement #2716
Conversation
@danielmain I compared the latest build with develop and found some issues on this PR:
|
…heck # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on 19620. Great work @danielmain 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @danielmain 💯
This PR Improves the Daedalus startup by avoiding unnecessary cardano-node restarts and extends the exit/update/kill timeouts to 5 minutes.
Testing Checklist
In order to test this you need to run Daedalus in an environment with less than 2 GB disk free space. In Linux, you can use for instance
fallocate -l 125G test.img
in order to create big files, so you overpass the 2 GB free space.Daedalus start with not enough space left
Daedalus start with not enough space left
Review Checklist
Test Scenarios
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board