New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-751] Fix issues related to minimum screen size #2719
Merged
nikolaglumac
merged 8 commits into
develop
from
fix/ddw-751-issues-related-to-minimum-screen-size
Oct 28, 2021
Merged
[DDW-751] Fix issues related to minimum screen size #2719
nikolaglumac
merged 8 commits into
develop
from
fix/ddw-751-issues-related-to-minimum-screen-size
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miorsufianiohk
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mchappell . LGTM 👍 . Tested on 19401 Slack discussion here for reference
dmitrii-gaico
approved these changes
Oct 25, 2021
mchappell
force-pushed
the
fix/ddw-751-issues-related-to-minimum-screen-size
branch
from
October 26, 2021 07:31
9f9b9e3
to
db3c482
Compare
ManusMcCole
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @mchappell 👍
gabriela-ponce
approved these changes
Oct 27, 2021
iohk-bors
bot
deleted the
fix/ddw-751-issues-related-to-minimum-screen-size
branch
October 28, 2021 15:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends components in both the initial settings screen, and app update overlay to account for minimum screen sizes
Todos
Screenshots
Testing Checklist
Test Scenarios
Scenario 1 - Check the responsiveness when release notes contain a large text
Scenario 2 - Check the scrollbar on minimum size
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board