Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-751] Fix issues related to minimum screen size #2719

Merged

Conversation

mchappell
Copy link
Contributor

@mchappell mchappell commented Oct 21, 2021

This amends components in both the initial settings screen, and app update overlay to account for minimum screen sizes

Todos

  • Add scrollbar to initial settings screen
  • Adjust minimum height of release notes in app update overlay

Screenshots

Screenshot 2021-10-21 at 10 57 00

Screenshot 2021-10-21 at 10 56 56

Screenshot 2021-10-21 at 14 53 26

Screenshot 2021-10-21 at 14 53 42


Testing Checklist


Test Scenarios

Scenario 1 - Check the responsiveness when release notes contain a large text

Given that Daedalus is on its minimum size
And a software update was prompted
And the text on the releases notes exceeds the maximum of the lines without scrolling
When I validate the "Software update available" screen
Then I can see that the link "Postpone the update" is clearly visible
And there is some margin below it

Scenario 2 - Check the scrollbar on minimum size

Given that Daedalus was just installed on a clean state
And is on its minimum size
And I am on the initial setup screen
When I validate the screen
Then I can see a scroll bar is displayed to fit the form container

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mchappell . LGTM 👍 . Tested on 19401 Slack discussion here for reference

@mchappell mchappell force-pushed the fix/ddw-751-issues-related-to-minimum-screen-size branch from 9f9b9e3 to db3c482 Compare October 26, 2021 07:31
Copy link

@ManusMcCole ManusMcCole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mchappell 👍

@nikolaglumac nikolaglumac merged commit 8827457 into develop Oct 28, 2021
@iohk-bors iohk-bors bot deleted the fix/ddw-751-issues-related-to-minimum-screen-size branch October 28, 2021 15:54
@nikolaglumac nikolaglumac added release-4.5.0 Daedalus Mainnet and removed ⏳release-vNext labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-4.5.0 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants