New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-759] Over-saturation warning #2733
Conversation
@mchappell Here's a list of the issues @dmitrii-gaico and I found on 19556:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on 19570. Great work @mchappell 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @mchappell 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mchappell 💯 🚀
source/renderer/app/components/staking/delegation-setup-wizard/DelegationSetupWizardDialog.js
Outdated
Show resolved
Hide resolved
...renderer/app/components/staking/delegation-setup-wizard/DelegationStepsConfirmationDialog.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mchappell 🎉
This PR adds warning message in the delegation wizard to warn users if over-saturation will occur when delegation to a pool.
Todos
Screenshots
Testing Checklist
Test Scenario
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board