New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-824] Fix app update on specific platform #2759
[DDW-824] Fix app update on specific platform #2759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @tomislavhoracek . Tested on build 19848 Mainnet/Flight/Testnet for all 3 platforms Win/Lin/Mac 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @tomislavhoracek 🚀
…atform # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tomislavhoracek this is a huge help for testing the automatic update!
This PR introduces a fix for app update on specific platform.
Todos
4.5.2
) or merge develop with version updateisDev
flag to FAKED new loader once QA is doneScreenshots
- No screenshots
Testing Checklist
NOTES:
What we want to simulate:
Faked News:
https://github.com/input-output-hk/daedalus/blob/f5c2b5470dbc45c2b0d0e800f3f35dab44786709/source/renderer/app/config/newsfeed-files/news-automatic-update.dummy.json
Testing:
1. Windows
Load News with current (not faked) Daedalus app version
daedalus.stores.newsFeed.setFakedNewsfeed({ isAutomaticUpdateTest: true })
Now you should see available update to version 5.1.0
Refresh Daedalus
Now we will fake Daedalus version 5.1.0 to simulate app update (finished)
daedalus.stores.newsFeed.setFakedNewsfeed({ isAutomaticUpdateTest: true, appVersion: "5.1.0" })
You should see available update to 5.1.1 and release notes for 5.1.0
Refresh Daedalus
Now we will fake Daedalus version 5.1.1 to simulate app update (finished)
daedalus.stores.newsFeed.setFakedNewsfeed({ isAutomaticUpdateTest: true, appVersion: "5.1.1" })
You should not see available updates but you should see 5.1.1 release notes
2. Mac / Linux
Load News with current (not faked) Daedalus app version
daedalus.stores.newsFeed.setFakedNewsfeed({ isAutomaticUpdateTest: true })
Now you should see available update to version 5.1.0
Refresh Daedalus
Now we will fake Daedalus version 5.1.0 to simulate app update (finished)
daedalus.stores.newsFeed.setFakedNewsfeed({ isAutomaticUpdateTest: true, appVersion: "5.1.0" })
You should see release notes for 5.1.0. You should not see available update to version 5.1.1 because that update is declared as Windows ONLY
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board