New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-852] Improve Stake Pools list view attention #2847
Conversation
56aaf37
to
0b1d128
Compare
We do! @renanvalentin can we have it? Just so we make sure everyone knows the list view exists. |
@daniloprates didn't we want to have this popup "pre-opened" for the first visit? @daniloprates @alexander-rukin should we do this in another ticket? Otherwise it will slight increase the scope of this one. |
@alexander-rukin @daniloprates added tooltip for list view. The user has to click on the list view button in order to register "seen" event. Does it makes sense? |
It can act like this:
cc @daniloprates |
position is a bit wrong -> we use 4px distance from element for tooltip positioning, and in this case element we are pointing to is icon, not container - reference https://zpl.io/VOEEv6r |
bb4f3ca
to
0f42f7e
Compare
@alexander-rukin created a new issue to fix the zIndex problem as it will result in regression testing: |
0f42f7e
to
33d1357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @renanvalentin . Tested on 20763 👍
33d1357
to
f0ec96e
Compare
@alexander-rukin should've been fixed now |
current hover is 1 -> should be 0.7 |
@alexander-rukin done 👏 |
screencast.2022-02-10.18-38-53.mp4I've noticed strange behaviour =/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
This PR separate the buttons from the search bar.
Todos
Screenshots
Testing Checklist
Test Scenarios
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrelease-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review