New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-940] Use the new faker.js npm module #2855
Conversation
Stupid question @marcin-mazurek what was wrong with the old one 🤔? |
@danielmain it's gone, the author deleted the repository: https://www.theregister.com/2022/01/10/npm_fakerjs_colorsjs/ Fortunately NPM doesn't allow people to delete packages anymore, so it didn't break our code, but without the update we're not going to be able to get any updates or security fixes (I know it's rather unlikely but still). |
d4cad8c
to
2bb1ab7
Compare
@danielmain In the Slack thread Tomislav raised a concern about potential impact on installers due to changing externals, however I checked installers on all platforms and they are not affected, Daedalus successfully installs and launches. I believe we should be able to merge this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just one small suggestion.
Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io>
This PR replaces the unpublished faker.js library with its successor.
Todos
Screenshots
Testing Checklist
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review