Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-940] Use the new faker.js npm module #2855

Merged
merged 11 commits into from Mar 22, 2022

Conversation

marcin-mazurek
Copy link
Contributor

@marcin-mazurek marcin-mazurek commented Feb 3, 2022

This PR replaces the unpublished faker.js library with its successor.

Todos

  • TODO

Screenshots

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@marcin-mazurek marcin-mazurek self-assigned this Feb 4, 2022
@marcin-mazurek marcin-mazurek requested review from a team February 4, 2022 10:28
@danielmain
Copy link
Contributor

Stupid question @marcin-mazurek what was wrong with the old one 🤔?

@marcin-mazurek
Copy link
Contributor Author

marcin-mazurek commented Feb 8, 2022

@danielmain it's gone, the author deleted the repository:

https://www.theregister.com/2022/01/10/npm_fakerjs_colorsjs/
https://www.npmjs.com/package/faker
https://github.com/marak/Faker.js/

Fortunately NPM doesn't allow people to delete packages anymore, so it didn't break our code, but without the update we're not going to be able to get any updates or security fixes (I know it's rather unlikely but still).

@marcin-mazurek
Copy link
Contributor Author

@danielmain In the Slack thread Tomislav raised a concern about potential impact on installers due to changing externals, however I checked installers on all platforms and they are not affected, Daedalus successfully installs and launches. I believe we should be able to merge this one

Copy link
Contributor

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just one small suggestion.

source/renderer/app/config/generateStakePoolFakeData.ts Outdated Show resolved Hide resolved
Marcin Mazurek and others added 2 commits March 22, 2022 16:14
@danielmain danielmain removed the WIP label Mar 22, 2022
@danielmain danielmain merged commit a0e800f into develop Mar 22, 2022
@danielmain danielmain deleted the chore/ddw-940-update-faker branch March 22, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants