New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-675] Catalyst dynamic content #2856
[DDW-675] Catalyst dynamic content #2856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lucas-barros great job! This feature will be valuable for next catalyst funds. 🚀
c5c843d
to
1c28bdb
Compare
@lucas-barros is it worth adding "api error" state to storybook? |
https://zpl.io/Pqz9Ymm Can you pls also update title to be semibold like in designs (it also should be fixed for those titles "Fund7" "Fund8" as they use same style) @daniloprates my suggestion is to swap medium and light highlighting and add dots "." in the end of sencences. Wdyt? |
@alexander-rukin I've made the updates. Storybook also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
noticed that title is not per design it's 19px font size -> should be 18px and it lacks letter-spacing you can fix it here or pls create a card for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀 Just few comments/suggestions.
source/renderer/app/components/voting/voting-info/VotingInfo.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
This PR changes how catalyst fund information are retrieved, from hard coded values to values fetched from catalyst API. A new message was added in case of errors when retrieving data from API.
To force switch between phases during tests:
window.daedalus.stores.voting._checkFundPhase(new Date('Jan 20, 2022, 11:00 UTC'))
To force API error message:
window.daedalus.stores.voting._checkFundPhase()
Access voting screen on testnet
daedalus.stores.app._updateRouteLocation({route: "/voting/registration"})
Phases
Snapshot: Jan 6, 2022, 11:00 UTC
Voting: Jan 20, 2022, 11:00 UTC - Feb 3, 2022, 10:59 UTC
Tallying: Feb 3, 2022, 11:00 UTC - Feb 9, 2022, 23:59 UTC
Results: Feb 10, 2022
Data fetched from API:
Data not present on API
Screens affected:
Todos
Screenshots
Testing Checklist
Test Scenario
Validate voting when API is unavailable
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)In case of dependency changesyarn.lock
file is updatedCode Quality
Testing
After Review