Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-939] Fix Stake Pools tooltip z-index #2863

Merged
merged 5 commits into from Feb 15, 2022
Merged

Conversation

renanvalentin
Copy link
Contributor

@renanvalentin renanvalentin commented Feb 7, 2022

This PR renders the search stake pools buttons tooltip behind the topbar.

Todos

  • TODO

Screenshots

Develop branch
Screen Shot 2022-02-07 at 15 56 30

PR
Screen Shot 2022-02-11 at 16 59 36
Screen Shot 2022-02-11 at 16 59 40
Screen Shot 2022-02-11 at 16 58 03
Screen Shot 2022-02-11 at 16 58 08

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@renanvalentin renanvalentin self-assigned this Feb 8, 2022
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job @renanvalentin . Tested on 20911 👍

@danielmain danielmain merged commit 6312d11 into develop Feb 15, 2022
@danielmain danielmain deleted the fix/ddw-939-fix-zindex branch February 15, 2022 20:23
renanvalentin added a commit that referenced this pull request Mar 7, 2022
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
renanvalentin added a commit that referenced this pull request Mar 7, 2022
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
renanvalentin added a commit that referenced this pull request Mar 7, 2022
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants