New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-939] Fix Stake Pools tooltip z-index #2863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-barros
approved these changes
Feb 7, 2022
przemyslaw-wlodek
approved these changes
Feb 8, 2022
gabriela-ponce
approved these changes
Feb 8, 2022
renanvalentin
force-pushed
the
fix/ddw-939-fix-zindex
branch
from
February 11, 2022 20:02
16024de
to
bf89ad0
Compare
miorsufianiohk
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job @renanvalentin . Tested on 20911 👍
alexander-rukin
approved these changes
Feb 15, 2022
renanvalentin
force-pushed
the
fix/ddw-939-fix-zindex
branch
from
February 15, 2022 17:26
aa5d0ea
to
8b03f1e
Compare
renanvalentin
added a commit
that referenced
this pull request
Mar 7, 2022
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
renanvalentin
added a commit
that referenced
this pull request
Mar 7, 2022
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
renanvalentin
added a commit
that referenced
this pull request
Mar 7, 2022
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renders the search stake pools buttons tooltip behind the topbar.
Todos
Screenshots
Develop branch
PR
Testing Checklist
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review