Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-964] Showing progress of all three sync types at once on loading screen #2877

Merged
merged 17 commits into from Feb 21, 2022
Merged

[DDW-964] Showing progress of all three sync types at once on loading screen #2877

merged 17 commits into from Feb 21, 2022

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Feb 15, 2022 •
edited

This PR improves the syncing screen by showing progresses of all three sync types at once.

Screenshots

image

image

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@szymonmaslowski szymonmaslowski self-assigned this Feb 16, 2022
@szymonmaslowski szymonmaslowski marked this pull request as ready for review February 16, 2022 12:21
renanvalentin
renanvalentin approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@renanvalentin renanvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @szymonmaslowski 🚀

307sagar
307sagar approved these changes Feb 16, 2022
View reviewed changes
Copy link

@307sagar 307sagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good ! Specially on adding those blocksync attr in SynConnecting comp

marcin-mazurek
marcin-mazurek suggested changes Feb 16, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
source/common/types/cardano-node.types.ts Show resolved Hide resolved
source/renderer/app/components/loading/syncing-connecting/SyncingConnectingStatus.tsx Show resolved Hide resolved
source/renderer/app/components/loading/syncing-connecting/SyncingConnectingStatus.tsx Outdated Show resolved Hide resolved
source/renderer/app/components/loading/syncing-connecting/SyncingConnectingStatus.tsx Outdated Show resolved Hide resolved
source/renderer/app/components/loading/syncing-connecting/SyncingProgress/SyncingProgress.tsx Show resolved Hide resolved
source/renderer/app/components/loading/syncing-connecting/SyncingProgress/SyncingProgress.tsx Show resolved Hide resolved
storybook/stories/nodes/syncing/SyncingConnecting.stories.tsx Outdated Show resolved Hide resolved
alexander-rukin
alexander-rukin approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szymonmaslowski
[DDW-964] Base decision about rendering progresses on the cardano nod…
2c80a9f 
…e state instead of specific translation messages
@danielmain danielmain merged commit 10222ac into develop Feb 21, 2022
@danielmain danielmain deleted the feature/ddw-964 branch February 21, 2022 11:39
renanvalentin added a commit that referenced this pull request Mar 7, 2022
@szymonmaslowski @danielmain @renanvalentin
[DDW-964] Showing progress of all three sync types at once on loading…
98a824f 
… screen (#2877)

Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io>
renanvalentin added a commit that referenced this pull request Mar 7, 2022
@szymonmaslowski @danielmain @renanvalentin
[DDW-964] Showing progress of all three sync types at once on loading…
cb45d7d 
… screen (#2877)

Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io>
renanvalentin added a commit that referenced this pull request Mar 7, 2022
@szymonmaslowski @danielmain @renanvalentin
[DDW-964] Showing progress of all three sync types at once on loading…
35ec208 
… screen (#2877)

Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-rukin alexander-rukin alexander-rukin approved these changes

@renanvalentin renanvalentin renanvalentin approved these changes

@marcin-mazurek marcin-mazurek marcin-mazurek approved these changes

@gabriela-ponce gabriela-ponce gabriela-ponce approved these changes

@307sagar 307sagar 307sagar approved these changes

@dmitrii-gaico dmitrii-gaico dmitrii-gaico approved these changes

Assignees

@szymonmaslowski szymonmaslowski

Labels
feature release-4.9.0 run Chromatic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@szymonmaslowski @alexander-rukin @renanvalentin @marcin-mazurek @gabriela-ponce @307sagar @dmitrii-gaico @danielmain