Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-992] Fix position of popup on syncing screen #2921

Merged
merged 4 commits into from Mar 25, 2022
Merged

[DDW-992] Fix position of popup on syncing screen #2921

merged 4 commits into from Mar 25, 2022

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Mar 14, 2022 •
edited by marcin-mazurek

This PR fixes the size of space between question mark icon and the tooltip.

There is no need for QAs to test those changes.

This PR also fixes the incorrect "Add" Japanese translation in token picker (DDW-1035).

Screenshots

Before After
image image

Incorrect translation fixed:
image

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@szymonmaslowski szymonmaslowski requested review from alexander-rukin and a team March 14, 2022 11:00
@szymonmaslowski szymonmaslowski self-assigned this Mar 14, 2022
@szymonmaslowski szymonmaslowski requested a review from a team March 14, 2022 11:42
@marcin-mazurek
Copy link
Contributor

Should this be fixed too? 158158221-49745f56-f1ae-4fa3-9398-197e702c1996

CC @alexander-rukin

@alexander-rukin
Copy link
Contributor

alexander-rukin commented Mar 14, 2022 •
edited

image

these are few steps overlapped, it doesn't form circle 🤔

image

Checked other spinner to be sure, this from staking center is ok

@szymonmaslowski
Copy link
Contributor Author

Should this be fixed too? 158158221-49745f56-f1ae-4fa3-9398-197e702c1996

CC @alexander-rukin

@marcin-mazurek Good catch! This definitely should be fixed but IMO it should be done as part of other ticket. This is issue of the PopOver component which comes from react polymorph and probably it affects other cases across our application - it is not specific to the issue fixed by this PR and it should be rather fixed globally.

@szymonmaslowski
Copy link
Contributor Author

image

these are few steps overlapped, it doesn't form circle 🤔

image

Checked other spinner to be sure, this from staking center is ok

@alexander-rukin I think there is a separate ticket for the spinner bug. In this PR I didn't change anything regarding it.

@alexander-rukin
Copy link
Contributor

@alexander-rukin I think there is a separate ticket for the spinner bug. In this PR I didn't change anything regarding it.

aaahh... i was checking completely different thing sorry ((

alexander-rukin
alexander-rukin approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmitrii-gaico dmitrii-gaico self-requested a review March 23, 2022 10:29
@miorsufianiohk miorsufianiohk self-requested a review March 23, 2022 11:39
@marcin-mazurek marcin-mazurek mentioned this pull request Mar 23, 2022
Closed
marcin-mazurek
marcin-mazurek reviewed Mar 23, 2022
View reviewed changes
source/renderer/app/i18n/locales/ja-JP.json
@@ -1187,7 +1187,7 @@
"wallet.summary.transactionsList.syncingTransactionsMessage": "ウォレットのトランザクション履歴は現在ブロックチェーンと同期中です。",
"wallet.summary.transactionsList.todayLabel": "今日",
"wallet.summary.transactionsList.yesterdayLabel": "昨日",
"wallet.token.picker.addButtonLabel": "キャンセル",
"wallet.token.picker.addButtonLabel": "追加する",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agreed with Szymon to add this tiny fix to address the issue from user report: #2931
Slack thread: https://input-output-rnd.slack.com/archives/GGKFXSKC6/p1648039378845489, https://input-output-rnd.slack.com/archives/CBECZ2K47/p1648025188531639

miorsufianiohk
miorsufianiohk approved these changes Mar 24, 2022
View reviewed changes
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @szymonmaslowski. Tested on 21363

@danielmain
Merge branch 'develop' into feature/ddw-992
e1b0a97 
# Conflicts:
#	CHANGELOG.md
danielmain
danielmain approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @szymonmaslowski !

@danielmain danielmain merged commit 38fc0ed into develop Mar 25, 2022
@danielmain danielmain deleted the feature/ddw-992 branch March 25, 2022 16:25
lucas-barros pushed a commit that referenced this pull request Apr 25, 2022
@danielmain @lucas-barros
Merge pull request #2921 from input-output-hk/feature/ddw-992
ed4e44e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-mazurek marcin-mazurek marcin-mazurek approved these changes

@alexander-rukin alexander-rukin alexander-rukin approved these changes

@renanvalentin renanvalentin renanvalentin approved these changes

@danielmain danielmain danielmain approved these changes

@gabriela-ponce gabriela-ponce gabriela-ponce approved these changes

@shawnbusuttil shawnbusuttil shawnbusuttil approved these changes

@miorsufianiohk miorsufianiohk miorsufianiohk approved these changes

@dmitrii-gaico dmitrii-gaico Awaiting requested review from dmitrii-gaico

Assignees

@szymonmaslowski szymonmaslowski

Labels
bug release-4.10.0 run Chromatic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@szymonmaslowski @marcin-mazurek @alexander-rukin @renanvalentin @danielmain @gabriela-ponce @shawnbusuttil @miorsufianiohk