Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1022] Use new version of ledgerjs (@cardano-foundation/ledgerjs-hw-app-cardano) #2930

Merged
merged 8 commits into from Apr 4, 2022

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Mar 23, 2022

This PR introduces the new version of @cardano-foundation/ledgerjs-hw-app-cardano

Todos

  • TODO

Screenshots

Testing Checklist

Regression document (ledger scenarios only)


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@szymonmaslowski szymonmaslowski marked this pull request as draft March 23, 2022 07:02
@szymonmaslowski szymonmaslowski self-assigned this Mar 23, 2022
@szymonmaslowski szymonmaslowski requested a review from a team March 23, 2022 07:02
@ManusMcCole
Copy link

Hi @szymonmaslowski. Here are 2 scenarios that are broken for both Ledger S and X. If the user initiates any transaction with the device physically disconnected and then connects the device when Daedalus asks to is resulting in "Transaction Confirmation failed error". See Screenshot. That same console error message also pops up during succesfull transactions so im not sure how useful it ill be for debugging

Scenario 2. Plugin Ledger Device.Unlock it(But don't enter cardano app).Open Daedalus. Attempt to make a transaction. Device gets left stuck at message Connect the "Ledger Nano S device" and enter your pin to unlock it message. See Screenshot

renanvalentin added a commit that referenced this pull request Mar 25, 2022
renanvalentin added a commit that referenced this pull request Mar 31, 2022
@szymonmaslowski szymonmaslowski changed the title [DDW-1022] Use rc version of ledgerjs [DDW-1022] Use new version of ledgerjs (@cardano-foundation/ledgerjs-hw-app-cardano) Apr 1, 2022
@szymonmaslowski szymonmaslowski requested a review from a team April 1, 2022 15:01
@szymonmaslowski szymonmaslowski marked this pull request as ready for review April 1, 2022 15:03
Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @szymonmaslowski

@danielmain danielmain merged commit 2209f28 into develop Apr 4, 2022
@danielmain danielmain deleted the feature/ddw-1022 branch April 4, 2022 13:59
renanvalentin added a commit that referenced this pull request Apr 4, 2022
renanvalentin added a commit that referenced this pull request Apr 4, 2022
renanvalentin added a commit that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants