New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1022] Use new version of ledgerjs (@cardano-foundation/ledgerjs-hw-app-cardano) #2930
Conversation
Hi @szymonmaslowski. Here are 2 scenarios that are broken for both Ledger S and X. If the user initiates any transaction with the device physically disconnected and then connects the device when Daedalus asks to is resulting in "Transaction Confirmation failed error". See Screenshot. That same console error message also pops up during succesfull transactions so im not sure how useful it ill be for debugging Scenario 2. Plugin Ledger Device.Unlock it(But don't enter cardano app).Open Daedalus. Attempt to make a transaction. Device gets left stuck at message Connect the "Ledger Nano S device" and enter your pin to unlock it message. See Screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @szymonmaslowski
This PR introduces the new version of
@cardano-foundation/ledgerjs-hw-app-cardano
Todos
Screenshots
Testing Checklist
Regression document (ledger scenarios only)
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review