Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1061] Downloaded installer being left behind after wallet is updated to latest version #2941

Merged
merged 7 commits into from Jul 4, 2022

Conversation

shawnbusuttil
Copy link
Contributor

@shawnbusuttil shawnbusuttil commented Mar 31, 2022

This PR intends to fix the problem where we have downloaded installers being left behind after Daedalus is updated.

Screenshots

No UI changes.

Local Testing Steps:

  1. Change package.json to 4.8.0.
  2. Run the local environment.
  3. Wait for the download to finish. You don't have to go through the installation as it will just install the Testnet without the updated logic.
  4. Make sure you have the finished installer in the Daedalus Testnet state directory downloads folder.
  5. Stop the environment.
  6. Change package.json to 4.9.0.
  7. Run the local environment.
  8. Open the downloads folder in state directory. The installer shouldn't be there anymore.

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@shawnbusuttil shawnbusuttil requested a review from a team March 31, 2022 18:14
@shawnbusuttil shawnbusuttil self-assigned this Mar 31, 2022
@shawnbusuttil shawnbusuttil changed the title test commit for DDW-1061 [DDW-1061] Downloaded installer being left behind after wallet is updated to latest version. Apr 1, 2022
@shawnbusuttil shawnbusuttil changed the title [DDW-1061] Downloaded installer being left behind after wallet is updated to latest version. [DDW-1061] Downloaded installer being left behind after wallet is updated to latest version Apr 1, 2022
@shawnbusuttil shawnbusuttil force-pushed the fix/ddw-1061-download-file-remains-after-update branch from 7cfdba3 to f443d6d Compare April 5, 2022 12:26
@danielmain danielmain removed the WIP label Apr 7, 2022
@shawnbusuttil shawnbusuttil force-pushed the fix/ddw-1061-download-file-remains-after-update branch from 793a79c to 9b488bd Compare April 8, 2022 09:37
@danielmain danielmain force-pushed the fix/ddw-1061-download-file-remains-after-update branch from 5f7ce78 to 6014690 Compare April 11, 2022 16:33
@danielmain
Copy link
Contributor

Tested successfully using tweaks and a special build. So @daedalus-qa you don't need to test it.
zip-file-deleted

Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawnbusuttil great Job. Tested and created a video

@shawnbusuttil
Copy link
Contributor Author

@shawnbusuttil great Job. Tested and created a video

Thank you for your help! 😃

@danielmain
Copy link
Contributor

danielmain commented Apr 12, 2022

Tested on MacOs

mac.mp4

@danielmain
Copy link
Contributor

Tested on Windows 11 cc: @input-output-hk/daedalus-qa

win.mp4

@dmitrii-gaico dmitrii-gaico self-requested a review April 26, 2022 12:03
@danielmain danielmain merged commit 3b34f67 into develop Jul 4, 2022
@iohk-bors iohk-bors bot deleted the fix/ddw-1061-download-file-remains-after-update branch July 4, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants