New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1061] Downloaded installer being left behind after wallet is updated to latest version #2941
Merged
danielmain
merged 7 commits into
develop
from
fix/ddw-1061-download-file-remains-after-update
Jul 4, 2022
Merged
[DDW-1061] Downloaded installer being left behind after wallet is updated to latest version #2941
danielmain
merged 7 commits into
develop
from
fix/ddw-1061-download-file-remains-after-update
Jul 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbusuttil
changed the title
test commit for DDW-1061
[DDW-1061] Downloaded installer being left behind after wallet is updated to latest version.
Apr 1, 2022
shawnbusuttil
changed the title
[DDW-1061] Downloaded installer being left behind after wallet is updated to latest version.
[DDW-1061] Downloaded installer being left behind after wallet is updated to latest version
Apr 1, 2022
shawnbusuttil
force-pushed
the
fix/ddw-1061-download-file-remains-after-update
branch
from
April 5, 2022 12:26
7cfdba3
to
f443d6d
Compare
shawnbusuttil
force-pushed
the
fix/ddw-1061-download-file-remains-after-update
branch
from
April 8, 2022 09:37
793a79c
to
9b488bd
Compare
danielmain
force-pushed
the
fix/ddw-1061-download-file-remains-after-update
branch
from
April 11, 2022 16:33
5f7ce78
to
6014690
Compare
danielmain
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawnbusuttil great Job. Tested and created a video
…update # Conflicts: # CHANGELOG.md
Thank you for your help! 😃 |
Tested on MacOs mac.mp4 |
przemyslaw-wlodek
approved these changes
Apr 12, 2022
Tested on Windows 11 cc: @input-output-hk/daedalus-qa win.mp4 |
dmitrii-gaico
approved these changes
Apr 26, 2022
…update # Conflicts: # CHANGELOG.md
…update # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the problem where we have downloaded installers being left behind after Daedalus is updated.
Screenshots
No UI changes.
Local Testing Steps:
package.json
to4.8.0
.Daedalus Testnet
state directory downloads folder.package.json
to4.9.0
.Testing Checklist
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review