Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1086] Fix phrasing of insufficient funds for tokens message #2966

Conversation

lucas-barros
Copy link
Contributor

@lucas-barros lucas-barros commented Apr 20, 2022

This PR fixes the phrasing of of insufficient funds for tokens message.
Previous error message was “Insufficient funds to support tokens. A minimum of {someAdaAmount} ADA must remain in the wallet after this transaction.”.
It was incorrect because {someAdaAmount} is not the value that should remain after the transaction but the value missing so the transaction will leave enough ada in the wallet to support the tokens.

It also adds missings translations pointed out in this PR.

Todos

  • TODO

Screenshots

Screenshot from 2022-05-13 13-01-25
Screenshot from 2022-05-13 13-01-49

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@lucas-barros lucas-barros force-pushed the fix/ddw-1086-fix-phrasing-of-insufficient-funds-for-tokens-message branch from f32d78f to 1fbdda3 Compare April 20, 2022 18:02
@lucas-barros lucas-barros self-assigned this Apr 20, 2022
@lucas-barros lucas-barros changed the title [DDW-1086] Fix error message and display value to proceed [DDW-1086] Fix phrasing of insufficient funds for tokens message Apr 20, 2022
@lucas-barros lucas-barros marked this pull request as ready for review April 22, 2022 12:29
@lucas-barros lucas-barros force-pushed the fix/ddw-1086-fix-phrasing-of-insufficient-funds-for-tokens-message branch from dfe0199 to f43e706 Compare April 22, 2022 13:18
@miorsufianiohk
Copy link

Hi @daniloprates , could we confirm how do you want to proceed with thia PR as discussed here please, thank you 🙏

Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @lucas-barros 👍 . Tested on 21771

@ManusMcCole ManusMcCole self-requested a review May 16, 2022 20:30
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! 👏

@DominikGuzei DominikGuzei merged commit dcaba70 into develop May 17, 2022
@iohk-bors iohk-bors bot deleted the fix/ddw-1086-fix-phrasing-of-insufficient-funds-for-tokens-message branch May 17, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants