New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1086] Fix phrasing of insufficient funds for tokens message #2966
[DDW-1086] Fix phrasing of insufficient funds for tokens message #2966
Conversation
f32d78f
to
1fbdda3
Compare
dfe0199
to
f43e706
Compare
…-funds-for-tokens-message
Hi @daniloprates , could we confirm how do you want to proceed with thia PR as discussed here please, thank you 🙏 |
…-funds-for-tokens-message
…-funds-for-tokens-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @lucas-barros 👍 . Tested on 21771
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! 👏
This PR fixes the phrasing of of insufficient funds for tokens message.
Previous error message was
“Insufficient funds to support tokens. A minimum of {someAdaAmount} ADA must remain in the wallet after this transaction.”
.It was incorrect because
{someAdaAmount}
is not the value that should remain after the transaction but the value missing so the transaction will leave enough ada in the wallet to support the tokens.It also adds missings translations pointed out in this PR.
Todos
Screenshots
Testing Checklist
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersIf there are UI changes, Alexander Rukin assigned as an additional reviewerrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review