Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-1121] Update cardano-node to 1.35.2 #3021

Merged
merged 2 commits into from Aug 8, 2022
Merged

[DDW-1121] Update cardano-node to 1.35.2 #3021

merged 2 commits into from Aug 8, 2022

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Jul 25, 2022 •
edited by gabriela-ponce

This PR updates cardano-node to 1.35.2

Todos

Screenshots

n/a

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus requested review from danielmain and a team July 25, 2022 11:03
@michalrus michalrus self-assigned this Jul 25, 2022
@michalrus michalrus changed the title Update cardano-node to 1.35.2 [DDW-1121] Update cardano-node to 1.35.2 Jul 25, 2022
@danielmain danielmain added the WIP label Jul 25, 2022
renanvalentin
renanvalentin requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@renanvalentin renanvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @michalrus i did not see the WIP label before approving 😅

@michalrus
Copy link
Member Author

@renanvalentin I’ll re-request a review from you to reset the state then ^.^

@danielmain danielmain removed the WIP label Jul 29, 2022
@DominikGuzei DominikGuzei self-requested a review August 1, 2022 11:54
DominikGuzei
DominikGuzei approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This works for me to sync with the lastest testnet 👍

@dmitrii-gaico dmitrii-gaico self-requested a review August 5, 2022 08:03
miorsufianiohk
miorsufianiohk approved these changes Aug 5, 2022
View reviewed changes
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @michalrus 👍

@danielmain danielmain merged commit 6d19133 into develop Aug 8, 2022
@iohk-bors iohk-bors bot deleted the chore/cardano-node-1.35.2 branch August 8, 2022 07:17
@danielmain danielmain added release-5.0.0 Daedalus version 5.0.0 and removed ⏳release-vNext labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikGuzei DominikGuzei DominikGuzei approved these changes

@danielmain danielmain danielmain approved these changes

@gabriela-ponce gabriela-ponce gabriela-ponce approved these changes

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

@miorsufianiohk miorsufianiohk miorsufianiohk approved these changes

@dmitrii-gaico dmitrii-gaico dmitrii-gaico approved these changes

@renanvalentin renanvalentin Awaiting requested review from renanvalentin

Assignees

@michalrus michalrus

Labels
cardano-node chore release-5.0.0 Daedalus version 5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@michalrus @DominikGuzei @renanvalentin @danielmain @gabriela-ponce @przemyslaw-wlodek @miorsufianiohk @dmitrii-gaico