Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/daef 467 Fix all features eslint warnings #468

Merged
merged 13 commits into from Sep 12, 2017

Conversation

tomislavhoracek
Copy link
Contributor

@tomislavhoracek tomislavhoracek commented Sep 7, 2017

This PR introduces a fix for all features eslint warnings.
In this PR a new and working wallet-default.key is injected.

TODO:

  • Inspect one failing acceptance-test scenario: Scenario: User Sends Money from wallet with spending password to Receiver

@DominikGuzei
Copy link
Member

Reviewing this now …

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Everything looks good and is ready to merge when CI is green 👍

@DominikGuzei
Copy link
Member

Merging this now as the travis PR CI was successful

@DominikGuzei DominikGuzei merged commit c5bf8aa into master Sep 12, 2017
@nikolaglumac nikolaglumac deleted the fix/daef-467-fix-all-features-eslint-warnings branch September 12, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants