[CSM-458] Query postponeUpdate endpoint when postponing the update
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing this one now... |
| @@ -40,6 +41,7 @@ export default class NodeUpdateStore extends Store { | |||
| }; | |||
|
|
|||
| @action _postponeNodeUpdate = () => { | |||
| this.postponeUpdateRequest.execute(); | |||
There was a problem hiding this comment.
We should probably add some basic error handling here! E.g
@action _postponeNodeUpdate = async () => {
try {
await this.postponeUpdateRequest.execute();
this.isUpdatePostponed = true;
} catch(error) {
this.isUpdatePostponed = false;
}
There was a problem hiding this comment.
Agreed @DominikGuzei - the only part that worries me is the fact that we should add "submitting" state on postpone button AND handle error state in the UI as if this call fails we will not hide the update notification so the user should be noticed that the error happened...
There was a problem hiding this comment.
Yeah definitely, the whole error handling logic needs to be fleshed out for the UI
darko-mijic
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should make Daedalus query
postponeUpdateendpoint on postponing the update. The endpoint is introduced in input-output-hk/cardano-sl#1586. This is needed to avoid problem with postponing the update described in https://issues.serokell.io/issue/CSM-458?query=%23CSM%20-Resolved