New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow clients configure API features #794
Allow clients configure API features #794
Conversation
cfaa843
to
02371fb
Compare
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review tries to apply the perfection game protocol
I will describe what I like about this P.R. and then what improvement I can think of to make it perfect.
Ask for clarifications if my comments are not clear.
If you disagree with my comments, just ignore them and don’t answer or explain.
Hence I, in advance, approve the P.R.
What I like about this P.R.:
For me to find it perfect you would have to:
- I would make two distinct pull requests to separate the history topic from the formatting topic
- I would polish the git history to make the review easier to make. For instance, I would remove the commit Finish with the implementation and test and integrates the changes their to the appropriate commits
- I would remove commit Introduce a test that should prevent history display to avoid having tests that don't pass in the git history and commit both this test and the production code in the same commit
- see other improvement proposals inline
ec63cfc
to
90da78b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not looked at the tests yet, but the api.yaml must document the query parameters!
f048716
to
88d8363
Compare
8d7a6ce
to
7a268ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only minor improvements left (feel free to merge also without them).
7a268ac
to
384dd7f
Compare
384dd7f
to
4abaead
Compare
fix #380 #379 #371
Why
🌴 Some clients don't want to observe a historical server outputs.
🌴 Some want to have the transactions in the output displayed as CBOR.
What
Using the query parameters decide on the api server level what kind of output to serve.