timeouts and exceptions #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
coot
commented
Apr 13, 2023
•
coot
commented
- io-sim: fixed timeouts in presence of exceptions
- io-sim: code style
- io-sim: track reason why a thread is blocked
- io-sim: refactored timeout implementation
- io-sim: improved TimeoutException Show instance
This is an analogous fix to one applied to thread delays in b6cd525.
Moved NewTimeout closer to UpdateTimeout & CancelTimeout.
We need to distinguish between threads blocked on STM and threads blocked by other operations e.g. `threadDelay` or `throwTo`. This is necessary so that we don't accidentally unblock a thread which is blocked not on STM by updating a TVar on which it was previously blocked.
coot
force-pushed
the
coot/timeouts-and-exceptions
branch
from
a1656ff
to
556324b
Compare
|
The following tests (including nightly ones) passed:
|
coot
force-pushed
the
coot/timeouts-and-exceptions
branch
2 times, most recently
from
9385ed9
to
9d2591f
Compare
bolt12
approved these changes
Apr 14, 2023
This patch implements `timeout` in exactly the same way as `timeout` in `base` for threaded RTS.
Added tips on testing and a two useful tips for debugging.
coot
force-pushed
the
coot/timeouts-and-exceptions
branch
from
2b18f6b
to
28e8022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.