threadDelay: efficiently remove thread delay timer #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
approved these changes
Apr 18, 2023
coot
force-pushed
the
coot/timer-cancelation
branch
2 times, most recently
from
e51804c
to
34ab9c1
Compare
bolt12
approved these changes
Apr 18, 2023
coot
force-pushed
the
coot/timer-cancelation
branch
from
34ab9c1
to
602a4c0
Compare
Introduce a `DelayFrame` which allows us to access `TimeoutId`.
coot
force-pushed
the
coot/timer-cancelation
branch
from
602a4c0
to
692fed0
Compare
|
I hope the noise isn't too laud 😁. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we cannot track the information on which
ThreadDelaya thread is blocked in
threadStatusbecause it is cleared whena thread is rescheduled. This is too early. In the scenario we are
interested in, the thread is rescheduled when the thread receives an
exception and it's when we interpret the
Throwwe need to know theTimeoutIdof thatthreadDelay.We add a
threadDelayIdfield, which tracks the lastthreadDelayid.This field only cleared when the thread receives an exception, thus it's
life time is long enough to be useful.