-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): display reward account and deposit for info action proposal procedures #1340
Merged
mchappell
merged 1 commit into
main
from
fix/add-reward-account-and-deposit-to-info-action
Aug 6, 2024
Merged
fix(core): display reward account and deposit for info action proposal procedures #1340
mchappell
merged 1 commit into
main
from
fix/add-reward-account-and-deposit-to-info-action
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allure Report
processReports: ✅ test report for dbb9a1cf
|
vetalcore
approved these changes
Aug 6, 2024
ljagiela
pushed a commit
that referenced
this pull request
Aug 6, 2024
mchappell
added a commit
that referenced
this pull request
Aug 13, 2024
mchappell
added a commit
that referenced
this pull request
Aug 14, 2024
mchappell
added a commit
that referenced
this pull request
Aug 14, 2024
* build: add paper wallet dependencies * chore: add paper wallet translations * feat(extension): add pgp utility functions * feat(extension): update posthog experiment provider and feature flag manager * docs: add paper wallet flow typings * feat(extension): add whitespace replacement utility function * feat(extension): add paper wallet pdf generation functionality * feat: update existing wallet flows * feat: add paper wallet creation flow * feat: add paper wallet restoration flow * feat(extension): add paper wallet regeneration from settings * fix: exclude wallet template file from sonarcloud as incorrectly identifies security risk * test(extension): add test ids to ChooseRecoveryMethod.tx * test(extension): update existing onboarding tests after paper wallet implementation * test(extension): update existing analytics tests after paper wallet implementation * test(extension): update existing 'add new wallet' tests after paper wallet implementation * fix: add optional chaining when fetching feature flag posthog properties * refactor(extension): remove duplication of pgp public key handler * fix(extension): wait for full scan before trying to decode message * feat(extension): update wallet ada balance calculation for paper wallet overview * feat(extension): implement paper wallet feature analytics * chore: use latest lace-ui-toolkit package * fix: correct styling for print icon when used in button * fix: correct missing pgp public key validation messages * feat(extension): update wallet overview to shown additional balances * feat: remove excess feature flag checks and align single timeline for mnemonics * fix(extension): use formatted name for paper wallet download * fix: save validation to state to avoid rechecking on component remount * fix: use correct analytics events for recovery method selection * fix: camera release when navigating between other screens * fixup! feat(extension): implement paper wallet feature analytics * fix: coalesce cta condition into memoised variable * fix: remove duplicate onClick handler for restoration method * fix(extension): correct video display * feat(extension): update wallet overview display * feat(extension): add additional constraint on additional public key data regex * fix(extension): use whitespace replacement with underscore for paper wallet filename * fix: display correct timeline step for save paper wallet stage * fix: clear validation and only validate file name if upload success * fix: reset validation and pgp info state on tab change * fix: reset pgp validation state on stage change * fix(core): update paper wallet info card border width * style: extract inline styling into classnames * feat(extension): add warning modal for paper wallet closure * fix(extension): display coingecko credit once loading complete * feat(extension): simplify pgp public key validation * refactor: update pdf base template * fix: remove pgp info on restoration * refactor: adjust styles for pgp text area * fix: scrub data * feat(extension): add exit warning modal for paper wallet settings drawer * feat(extension): add copy icon to restore wallet overview * test(extension): update pgp checks * feat(extension): update restoration success clear clipboard on paste * test(extension): fix github token for e2e-split and set default values for some outputs (#1344) * test(extension): set default values for env variables in e2e-split (#1345) * test(extension): fix preprod_env name in e2e-split (#1347) * test(extension): do not reuse artifacts for e2e split (#1348) * fix: improve shared wallet related ui (#1346) * test(extension): new test lw-9095 (#1317) * test(extension): fix cardano services url in e2e split (#1349) * fix(core): display reward account and deposit for info action proposal procedures (#1340) * test(extension): use split e2e for daily regression (#1352) * test(extension): test maintenance 7 aug 2023 (#1356) * E2e add lace build artifact reuse and cancelling job (#1354) * test(extension): add option to run e2e tests on all networks (#1351) * fix(core): replaces Math.Random with window.crypto.getRandomValues implementation in simple-cipher (#1357) * chore: drop console logging in production (#1358) * chore: update lace-ui-toolkit version * chore: bump lace-ui-toolkit to 1.13.0 * chore: bump lace-ui-toolkit to 1.14.0 * fix: send-transaction password input label * refactor: update paper wallet copy * fix: remove paper wallet drawer warning modal * fix: update save paper wallet instruction * fix: revert to pgp entry on move back step * feat: add pgp validation messages * refactor: address styles * refactor: media selector always on top * fix: create paper wallet copy * feat(extension): update posthog paper wallet analytic events * feat(extension): camera error analytics event * feat(extension): restore flow paper wallet events * feat(extension): invert checks for scanning qr code * feat(extension): update pgp copy * feat(extension): update qr code scanning * feat(extension): prevent generate paper wallet from popup settings * feat(extension): add distinction between international and US paper sizing * feat(extension): update scanning and ending stream * feat: update analytic events * feat(extension): add fallback if price information or utxo provider not responding * fix: correct merge issue * fix: add missing useSecrets changes * fix: submit name on paper wallet creation * fix: use password.value for paper wallet settings * fix: redirect to assets page after adding a new wallet --------- Co-authored-by: wklos-iohk <wojciech.klos@iohk.io> Co-authored-by: shawnbusuttil <shawn-buzu@hotmail.co.uk> Co-authored-by: Lukasz Jagiela <12641433+ljagiela@users.noreply.github.com> Co-authored-by: John Oshalusi <john.oshalusi@iohk.io> Co-authored-by: Janusz Janus <janusz.janus@iohk.io> Co-authored-by: Emir Hodzic <emir.hodzich@gmail.com> Co-authored-by: Angel Castillo <Angel.Castillo@iohk.io> Co-authored-by: Martynas Kazlauskas <martynas.kazlauskas@iohk.io> Co-authored-by: przemyslaw.wlodek <przem.wlodek.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes