update dependencies #685
Closed
update dependencies #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapke
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Remember to update repo.nix files as well, these are like lockfiles from other package managers, but required (and managed) by nix to have build reproducible.
To do that:
- install nix (may get tricky on macOS Catalina 😅 )
- enter nix shell (
nix-shell) - run
sbtix-gen-all2command
build.sbt
Outdated
| @@ -16,8 +16,8 @@ val commonSettings = Seq( | |||
| val malletDeps = Seq( | |||
| Dependencies.scopt | |||
| ).flatten ++ Seq( | |||
| "org.jline" % "jline" % "3.1.2", | |||
| "net.java.dev.jna" % "jna" % "4.5.1" | |||
| "org.jline" % "jline" % "3.16.0", | |||
There was a problem hiding this comment.
using the occasion: shouldn't jline and jna be picked from project/Dependencies.scala as well?
There was a problem hiding this comment.
Moved to Dependencies.
|
@lemastero you have to sign all commits |
Closed
|
Could not sign old commits. I have created different PR: #692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update library dependencies.
(Current versions of monix and cats have some issues with diverging implicits so they are not updated.)
Proposed Solution
Important Changes Introduced
Testing
Tested by:
sbt clean test