[ETCM-715] Add new network metric (tried.peers) #959
Conversation
jb-lunatech
force-pushed
the
feature/ETCM-715-add-network-metric
branch
3 times, most recently
from
6084704
to
c37c525
Compare
| s"Trying to connect to ${nodesToConnect.size} more nodes." | ||
| s"Trying to connect to ${nodesToConnect.size} more nodes, " + | ||
| s"Total tried nodes ${triedNodes.size}, " + | ||
| s"Connected nodes ${connectedPeers.peers.size}." |
There was a problem hiding this comment.
This log message becomes a bit confusing like this, for example this is a log message when connecting to etc: Discovered 1154 (can connect to 790) nodes, Blacklisted 426 nodes, handshaked to 6/80, pending connection attempts 4. Trying to connect to 40 more nodes, Total tried nodes 435, Connected nodes 10.
There was a problem hiding this comment.
What about something like this?
Total number of discovered nodes 1154. Total number of connection attempts 435, blacklisted 426 nodes, connected to 10 nodes. Handshaked 6/80, pending connection attempts with 4 nodes. Trying to connect to 40 more nodes.
There was a problem hiding this comment.
agree, especially handshaked and connected showing different numbers is confusing.
and generally this looks like too much information
There was a problem hiding this comment.
Looking in more detail, the Connected nodes 10 is also confusing it is actually 6 handshaked and 4 pending, so maybe I would remove the Connected nodes 10 actually
jb-lunatech
force-pushed
the
feature/ETCM-715-add-network-metric
branch
from
c37c525
to
b476d49
Compare
Description
PeerManagerActorProposed Solution
This let Grafana compute the ratio. It is cleaner from the metrics and Scala code point of view, however it takes time to make it work in the Grafana dashboard.
The alternative is to set a ratio metric in Scala (with the drawback of having convoluted metrics)
Important Changes Introduced
Testing
build.shindocker/mantis