Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --debug flag to marconi-chain-index and marconi-sidechain-exp #286

Merged
merged 5 commits into from Jan 8, 2024

Conversation

berewt
Copy link
Contributor

@berewt berewt commented Jan 5, 2024

--debug will allow logging of the start/end of block processing on each indexer (and any other debug logs)

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense and have useful messages
    • Important changes are reflected in changelog.d of the affected packages
    • Relevant tickets are mentioned in commit messages
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting main unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • If relevant, reference the ADR in the PR and reference the PR in the ADR
    • Reviewer requested

Copy link
Contributor

@brendanrbrown brendanrbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me, and the app gives the expected output when run locally with the new flag.

Unsure what's up with the golden files test failures, except possibly whitespace issues.

@berewt
Copy link
Contributor Author

berewt commented Jan 8, 2024

I don't know either, the tests pass locally... So yes, likely an issue with the golden value. Maybe the golden-files whitespace has been trimmed...

@brendanrbrown
Copy link
Contributor

I don't know either, the tests pass locally...

Oh interesting. They fail for me locally.

Might have found the issue while puzzling over the difference:

By using cat -A on the CLI output vs. golden files, I see the CLI output has a Windows style \r\n newline character at the end of each line. The golden files don't.

@berewt
Copy link
Contributor Author

berewt commented Jan 8, 2024

We should have a golden file space insensitive mode... Can you accept the golden test values and push the corresponding commit? cabal test all --test-options=--accept

@berewt berewt merged commit a85b1a1 into main Jan 8, 2024
4 checks passed
@berewt berewt deleted the debugFlag branch January 8, 2024 18:03
@brendanrbrown brendanrbrown mentioned this pull request Jan 11, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants