New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster ledger state #287
Faster ledger state #287
Conversation
ab67fa7
to
63cbfa6
Compare
4bdd6d0
to
b2d30fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. My comments are minor and mostly about documentation, particularly in cases where it's unclear that bad values of certain parameters are possible.
The CI currently fails because of some fourmolu thing.
But the tests failed for me locally because of golden files: I went ahead and fixed those up as in #286, in case you were still having issues with whitespace.
marconi-cardano-chain-index/src/Marconi/Cardano/ChainIndex/CLI.hs
Outdated
Show resolved
Hide resolved
marconi-cardano-indexers/src/Marconi/Cardano/Indexers/EpochNonce.hs
Outdated
Show resolved
Hide resolved
marconi-cardano-indexers/src/Marconi/Cardano/Indexers/ExtLedgerStateCoordinator.hs
Outdated
Show resolved
Hide resolved
marconi-cardano-indexers/src/Marconi/Cardano/Indexers/ExtLedgerStateCoordinator.hs
Outdated
Show resolved
Hide resolved
marconi-cardano-indexers/src/Marconi/Cardano/Indexers/ExtLedgerStateCoordinator.hs
Show resolved
Hide resolved
marconi-cardano-indexers/src/Marconi/Cardano/Indexers/ExtLedgerStateCoordinator.hs
Show resolved
Hide resolved
marconi-cardano-indexers/src/Marconi/Cardano/Indexers/ExtLedgerStateCoordinator.hs
Show resolved
Hide resolved
* File indexer maintain a list of file in memory * Ledger state is maintained in memory * We use builder to serialise event in the file indexer * Add a batch-size flag
7baa077
to
9c213e6
Compare
I still have these issues (I think I was able to do it in the past though, which is weird). |
Let me know if you want me to push the whitespace fix again. |
e9fe231
to
2e08353
Compare
Several memory/speed improvement:
--batch-size
flagPre-submit checklist: