New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-6750: Parsing pretty printed Marlowe contracts #687
Conversation
92fa4f8
to
940a265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I am quite convinced the code is correct, and the test you wrote should give good coverage. I have written a couple of suggestions for improved usability and a couple of other minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, aside from the one concern I noted in a comment. Thanks!
0e1afc9
to
7f5b316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Co-authored-by: Pablo Lamela <pablo.lamela@iohk.io>
Co-authored-by: Pablo Lamela <pablo.lamela@iohk.io>
Co-authored-by: Pablo Lamela <pablo.lamela@iohk.io>
Co-authored-by: Pablo Lamela <pablo.lamela@iohk.io>
Co-authored-by: Pablo Lamela <pablo.lamela@iohk.io>
This PR addresses #645
Run
marlowe-cli format --help
to display the help of the newly introduced command.The goal is to provide a command line tool to allow conversion between pretty-printed Marlowe contracts and the JSON representation of a Marlowe contract (default). Note, that with another ticket we will introduce also an official grammar for pretty printed Marlowe in https://github.com/input-output-hk/marlowe, that will also allow blockchain agnositc parsing of Marlowe contracts.
Pre-submit checklist: