Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-3983 Added CHaP input map to nix flake. #24

Merged
merged 1 commit into from
Apr 3, 2023
Merged

PLT-3983 Added CHaP input map to nix flake. #24

merged 1 commit into from
Apr 3, 2023

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Mar 30, 2023

The CHaP input map is added to the nix flake.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@bwbush bwbush self-assigned this Mar 30, 2023
@bwbush bwbush requested a review from palas March 30, 2023 19:08
@bwbush bwbush marked this pull request as ready for review March 30, 2023 19:08
palas
palas approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good 👍

@bwbush bwbush merged commit 5f34000 into main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palas palas palas approved these changes

Assignees

@bwbush bwbush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwbush @palas