Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download unpack snapshots simultaneously #1183

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Aug 29, 2023

Content

This PR fuse together the download and unpack steps of the snapshot download command of the Mithril Client.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1115

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Test Results

    3 files  ±0    17 suites  ±0   5m 41s ⏱️ -1s
671 tests ±0  671 ✔️ ±0  0 💤 ±0  0 ±0 
727 runs  ±0  727 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7fbf329. ± Comparison against base commit e79b1b1.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview August 29, 2023 10:03 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just update the space requirements ratio and maybe rename the ChannelRead to something more clear

@Alenar Alenar force-pushed the ensemble/1115/download-unpack-snapshots-simultaneously branch 2 times, most recently from 4daa96e to dee7c96 Compare August 29, 2023 12:59
@Alenar Alenar force-pushed the ensemble/1115/download-unpack-snapshots-simultaneously branch from dee7c96 to 7fbf329 Compare August 29, 2023 13:14
@Alenar Alenar temporarily deployed to testing-preview August 29, 2023 14:11 — with GitHub Actions Inactive
@Alenar Alenar merged commit a2222e0 into main Aug 29, 2023
25 checks passed
@Alenar Alenar deleted the ensemble/1115/download-unpack-snapshots-simultaneously branch August 29, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make client download and extract the archive simultaneously
2 participants