-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download unpack snapshots simultaneously #1183
Merged
Alenar
merged 5 commits into
main
from
ensemble/1115/download-unpack-snapshots-simultaneously
Aug 29, 2023
Merged
Download unpack snapshots simultaneously #1183
Alenar
merged 5 commits into
main
from
ensemble/1115/download-unpack-snapshots-simultaneously
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just update the space requirements ratio and maybe rename the ChannelRead
to something more clear
It will be used to create a channel between the download thread and the unpack thread.
Alenar
force-pushed
the
ensemble/1115/download-unpack-snapshots-simultaneously
branch
2 times, most recently
from
August 29, 2023 12:59
4daa96e
to
dee7c96
Compare
Alenar
force-pushed
the
ensemble/1115/download-unpack-snapshots-simultaneously
branch
from
August 29, 2023 13:14
dee7c96
to
7fbf329
Compare
Alenar
deleted the
ensemble/1115/download-unpack-snapshots-simultaneously
branch
August 29, 2023 14:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fuse together the download and unpack steps of the
snapshot download
command of the Mithril Client.Pre-submit checklist
Issue(s)
Closes #1115