Fix building mithril-common with some features and targets combinatory #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/fix-build-common-feature-combinatory
branch
from
704d04e
to
2570abd
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
By using the `dep:` prefix when specifying the features (see the [rustbook](https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies) to know how this work). This means that all the features of the crates are manually defined by us and can be easilly retrieved using `cargo metadata`.
Alenar
force-pushed
the
djo/fix-build-common-feature-combinatory
branch
from
2570abd
to
079d148
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fix the building of mithril-common for all it's matrix of features and targets.
Some examples that raise errors right now:
test_toolsfeatures fails because it's need theColdKeyGeneratorthat's behind therandomfeature.--all-targetsdirective fails horribly (30 errors) because the tests use a lot of tools that are behind thetest_toolsfeature.fsandrandomfeatures would fails since theFakeObserveris behind thetest_toolsfeature that is disabled.Pre-submit checklist
Comments
In order to check more easily if a feature combinatory is failing a new target has been added to the mithril-common makefiles that compute all features combinatory (the "powerset" of features) and run a cargo clippy on them.