Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building mithril-common with some features and targets combinatory #1463

Merged
merged 5 commits into from Jan 26, 2024
Merged

Fix building mithril-common with some features and targets combinatory #1463

merged 5 commits into from Jan 26, 2024

Commits on Jan 26, 2024

  1. Enable features in mithril-common doc by adding the doc_cfg attribute

    @Alenar
    Alenar committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    869ee69 View commit details
    Browse the repository at this point in the history

  2. Fix mithril-common build when using individual flag

    @Alenar
    Alenar committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b2f444c View commit details
    Browse the repository at this point in the history

  3. Disable implicitly defined features in mithril-common 

    By using the `dep:` prefix when specifying the features (see the
[rustbook](https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies)
to know how this work).

This means that all the features of the crates are manually defined by
us and can be easilly retrieved using `cargo metadata`.
    @Alenar
    Alenar committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fafa570 View commit details
    Browse the repository at this point in the history

  4. Add target to mithril common makefile that check its powerset of feat… 

    …ures
    @Alenar
    Alenar committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0be63c5 View commit details
    Browse the repository at this point in the history

  5. Update mithril-common crate version

    @Alenar
    Alenar committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    079d148 View commit details
    Browse the repository at this point in the history