Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable substitution in npm publication workflow release #1596

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fix variable substitution in npm publication workflow release #1596

merged 1 commit into from
Mar 26, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Mar 26, 2024 •
edited
Loading

Content

This PR fixes the npm publication workflow release

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes 1595

jpraynaud
jpraynaud approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

Test Results

    3 files  ±0     42 suites  ±0   8m 39s ⏱️ -30s
  945 tests ±0    945 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 039 runs  ±0  1 039 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fc3f9f8. ± Comparison against base commit 8759bae.

@sfauvel sfauvel temporarily deployed to testing-sanchonet March 26, 2024 16:15 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit ffdfceb into main Mar 26, 2024
41 of 42 checks passed
@sfauvel sfauvel deleted the sfa/1595-fix-npm-publication-in-release-workflow branch March 26, 2024 16:24
@jpraynaud jpraynaud linked an issue Mar 27, 2024 that may be closed by this pull request
npm publication fails in Release workflow #1595
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm publication fails in Release workflow
3 participants
@sfauvel @Alenar @jpraynaud